From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755460AbdLOMfw (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 07:35:52 -0500
Received: from mail-wr0-f193.google.com ([209.85.128.193]:42298 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755052AbdLOMfv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 07:35:51 -0500
X-Google-Smtp-Source: ACJfBouordchAfDTMT3wZ83X5ubFC0Ff5Y1VjoR9l3CYQ/ZaAKH8zciNzAD4PsnkIy8Wa8AcJXVwlw==
Date: Fri, 15 Dec 2017 13:35:47 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu@gmail.com>
Subject: Re: [PATCH v2] x86: update/correct opcodes map
Message-ID: <20171215123547.246yrcy42l5kgppu@gmail.com>
References: <aac062d7-c0f6-96e3-5c92-ed299e2bd3da@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aac062d7-c0f6-96e3-5c92-ed299e2bd3da@infradead.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Update x86-opcode-map.txt based on the October 2017 Intel SDM publication.
> Correct INVPID to INVVPID.
> Add UD0 and UD1 instruction opcodes.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Masami Hiramatsu <masami.hiramatsu@gmail.com>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: x86 maintainers <x86@kernel.org>
> ---
> 
> v2 changes:
> . correct email address.
> . add full Grp10 table
> . use # comments as requested
> 
>  arch/x86/lib/x86-opcode-map.txt |   15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> 
> --- lnx-415-rc3.orig/arch/x86/lib/x86-opcode-map.txt
> +++ lnx-415-rc3/arch/x86/lib/x86-opcode-map.txt
> @@ -533,7 +533,7 @@ b5: LGS Gv,Mp
>  b6: MOVZX Gv,Eb
>  b7: MOVZX Gv,Ew
>  b8: JMPE (!F3) | POPCNT Gv,Ev (F3)
> -b9: Grp10 (1A)
> +b9: Grp10 (1A) # all UD1

This change breaks the tools/objtool parser:

  GEN      arch/x86/insn/inat-tables.c
 Semantic error at 536: # is not a separator
 arch/x86/Build:7: recipe for target 'arch/x86/insn/inat-tables.c' failed

so I left it out for the time being.

Thanks,

	Ingo