Re: [MPTCP] [RFC v3 00/15] TCP Extra-option framework for TCP-MD5 and SMC

[Christoph Paasch <cpaasch at apple.com>]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

On 12/12/17 - 16:05:16, Christoph Paasch wrote:
> On 12/12/17 - 15:40:20, Mat Martineau wrote:
> > 
> > On Mon, 11 Dec 2017, Christoph Paasch wrote:
> > 
> > > 3rd version of the set.
> > > 
> > > Now, fully tested and bugs fixed.
> > > 
> > 
> > One more question - can you elaborate on the testing you did? Were the keys
> > set before connecting, modified or deleted during while connected, etc.? Did
> > you build with KASAN or lockdep?
> 
> Yes, built with KASAN and full lockdep debugging.
> 
> I did tests where I set the keys on one side, not the other one and check
> the connections got rejected.
> 
> Then I tested setting the keys at the beginning.
> 
> I will do an additional test where I change the keys half-way through the
> connection.

FYI, just tested starting with a key set on client and listener, then after
accept() and a write/read, I set the key to 0 (thus removing MD5). Then
after a bunch of reads/writes I set again a different key.

Works as expected.


Christoph