All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Cannot rebuild autobuild
Date: Fri, 15 Dec 2017 21:22:46 +0100	[thread overview]
Message-ID: <20171215202245.y74stbkfdaysy3hp@dell5510> (raw)
In-Reply-To: <20171129211926.GA16373@x230>

Hi,

> > > So, this is a change in behaviour, and should be reported upstream as a
> > > bug. Will you do so?

TL;DR: No I don't, IMHO it's not a bug in make.

4fd5672 [1] which broke buildroot unified behaviour on different os, which is good. Since
this revision it behaves nearly the same as 3.81.  It's only coincidence that make from
current openSUSE Tumbleweed with make-sorted-glob.patch patch [2] behaves the same (this
patch is completely different from [1]).


I did comparison of make of these git versions: 3.81, 3.82, 4.2.1, 0ca3108 (last working
version on buildroot before fix b9d2d4cb4e), 4fd5672 (version which broke buildroot
b9d2d4cb4e~), 48c8a11 (current master) with this simple "project":

$ for i in a b c d; do touch $i.mk; sleep 1; done

$ cat > Makefile << EOF
$(info make: $(shell which make))
$(info make -v: $(shell make -v))

$(foreach i, $(sort $(wildcard *.mk)), $(info SORT $i))
$(foreach i, $(wildcard *.mk), $(info NOSORT $i))
include $(wildcard *.mk)
EOF


make version       | 3.81 | 3.82 | 4.2.1 | 4.2.1+[2] | 0ca3108 | 4fd5672
------------------------------------------------------------------------
wildcard the same  | yes  |  no  |  no   |    no     |   no    |   no
as sorted wildchard|      |      |       |           |
------------------------------------------------------------------------
wildcard the same  | yes  |  no  |  no   |    yes    |   no    |   yes
on different OS    |      |      |       |           |         |
------------------------------------------------------------------------
Breaks buildroot   |  no  |  no  |  no   |    yes    |   no    |   yes

NOTES:
wildcard changed in 3.82 and 4fd5672.
Behaviour on 48c8a11 (current master) is the same as on 4fd5672.
"4.2.1+[2]" is 4.2.1 + make-sorted-glob.patch patch [2].

[2] https://build.opensuse.org/package/view_file/Base:System/make/make-sorted-glob.patch?expand=1
[2] https://git.savannah.gnu.org/cgit/make.git/commit/?id=4fd56724ad281498d3c8b27a4b25b4070f6e4e65


Kind regards,
Petr

  reply	other threads:[~2017-12-15 20:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 10:27 [Buildroot] Cannot rebuild autobuild Petr Vorel
2017-11-13 11:06 ` Baruch Siach
2017-11-13 14:42 ` Petr Vorel
2017-11-14 22:44   ` Peter Seiderer
2017-11-15 12:58     ` Petr Vorel
2017-11-15 23:03       ` Arnout Vandecappelle
2017-11-15 23:19         ` Peter Seiderer
2017-11-15 23:40           ` Arnout Vandecappelle
2017-11-16  7:29             ` Petr Vorel
2017-11-16 13:43               ` Arnout Vandecappelle
2017-11-18 21:22                 ` Peter Seiderer
2017-11-20 21:44                   ` Yann E. MORIN
2017-11-18 21:32                 ` Peter Seiderer
2017-11-21 20:16                   ` Petr Vorel
2017-11-25 15:01                     ` Yann E. MORIN
2017-11-25 16:34                       ` Arnout Vandecappelle
2017-11-29 21:19                         ` Petr Vorel
2017-12-15 20:22                           ` Petr Vorel [this message]
2017-12-15 20:23                             ` [Buildroot] FW: " Kees van Unen
2017-11-16  7:14         ` [Buildroot] " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215202245.y74stbkfdaysy3hp@dell5510 \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.