From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 4/6] event/dpaa: add eventdev PMD Date: Sat, 16 Dec 2017 18:07:22 +0530 Message-ID: <20171216123722.GC17045@jerin> References: <20171215130828.14218-1-sunil.kori@nxp.com> <20171215130828.14218-5-sunil.kori@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, hemant.agrawal@nxp.com To: Sunil Kumar Kori Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0073.outbound.protection.outlook.com [104.47.41.73]) by dpdk.org (Postfix) with ESMTP id 2EA23237 for ; Sat, 16 Dec 2017 13:37:56 +0100 (CET) Content-Disposition: inline In-Reply-To: <20171215130828.14218-5-sunil.kori@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Fri, 15 Dec 2017 18:38:26 +0530 > From: Sunil Kumar Kori > To: jerin.jacob@caviumnetworks.com > CC: dev@dpdk.org, hemant.agrawal@nxp.com > Subject: [PATCH 4/6] event/dpaa: add eventdev PMD > X-Mailer: git-send-email 2.9.3 > > Signed-off-by: Sunil Kumar Kori Overall it looks good. Please split this patch to more logical grouping(logical grouping based on the struct rte_eventdev_ops ops) You can check the event_sw driver's initial git commits as reference.