Re: [PATCH 2/2] dpaa2: register dpaa2 mempool ops as active mempool

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Fri, 15 Dec 2017 15:54:43 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] dpaa2: register dpaa2 mempool ops as active
>  mempool
> X-Mailer: git-send-email 2.7.4
> 
> Detect if the DPAA2 mempool objects are present and they can
> serve as default mempool.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 -
>  drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c  | 6 ++++++
>  drivers/bus/fslmc/portal/dpaa2_hw_pvt.h   | 2 ++
>  drivers/mempool/dpaa2/dpaa2_hw_mempool.c  | 2 +-
>  4 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> index 91f4993..703e8b3 100644
> --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc
> +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> @@ -53,7 +53,6 @@ CONFIG_RTE_LIBRTE_VHOST_NUMA=n
>  # Compile Support Libraries for DPAA2
>  #
>  CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
> -CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="dpaa2"
>  CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n
>  
>  #
> diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
> index 334e1f5..5a6f292 100644
> --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
> +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
> @@ -64,6 +64,7 @@ dpaa2_create_dpbp_device(int vdev_fd __rte_unused,
>  {
>  	struct dpaa2_dpbp_dev *dpbp_node;
>  	int ret;
> +	static int active_pool;
>  
>  	/* Allocate DPAA2 dpbp handle */
>  	dpbp_node = rte_malloc(NULL, sizeof(struct dpaa2_dpbp_dev), 0);
> @@ -100,6 +101,11 @@ dpaa2_create_dpbp_device(int vdev_fd __rte_unused,
>  
>  	RTE_LOG(DEBUG, PMD, "DPAA2: Added [dpbp.%d]\n", dpbp_id);
>  
> +	if (!active_pool) {

I think, this global variable can be avoided. Why it needs to be under 
active_pool?