From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:34414 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966545AbdLSI1V (ORCPT ); Tue, 19 Dec 2017 03:27:21 -0500 Date: Tue, 19 Dec 2017 10:27:17 +0200 From: Sakari Ailus To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , "Lad, Prabhakar" , Songjun Wu , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kyungmin Park , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , Todor Tomov , Niklas =?iso-8859-1?Q?S=F6derlund?= , Ramesh Shanmugasundaram , Guennadi Liakhovetski , Maxime Coquelin , Alexandre Torgue , Benoit Parrot , Hyun Kwon , Laurent Pinchart , Michal Simek , Steve Longerbeam , Philipp Zabel , Greg Kroah-Hartman , Hans Verkuil , Petr Cvek , Pravin Shedge , Hugues Fruchet , Sebastian Reichel , "Gustavo A. R. Silva" , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure Message-ID: <20171219082717.3cs62f2lqaj4ib27@valkosipuli.retiisi.org.uk> References: <014b64d13c8b9d516afc3319a9de1a97b2a845de.1513625884.git.mchehab@s-opensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <014b64d13c8b9d516afc3319a9de1a97b2a845de.1513625884.git.mchehab@s-opensource.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, Dec 18, 2017 at 05:53:57PM -0200, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose those into structs, > as the criteria can go directly into the union. > > That makes easier to document it, as we don't need to document > weird senseless structs. > > At drivers, this makes even clearer about the match criteria. > > Acked-by: Sylwester Nawrocki > Signed-off-by: Mauro Carvalho Chehab I'm not sure this is needed but it doesn't break anything either. Feel free to add: Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ailus@iki.fi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure Date: Tue, 19 Dec 2017 10:27:17 +0200 Message-ID: <20171219082717.3cs62f2lqaj4ib27@valkosipuli.retiisi.org.uk> References: <014b64d13c8b9d516afc3319a9de1a97b2a845de.1513625884.git.mchehab@s-opensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:34414 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966545AbdLSI1V (ORCPT ); Tue, 19 Dec 2017 03:27:21 -0500 Content-Disposition: inline In-Reply-To: <014b64d13c8b9d516afc3319a9de1a97b2a845de.1513625884.git.mchehab@s-opensource.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , "Lad, Prabhakar" , Songjun Wu , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kyungmin Park , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , Todor Tomov , Niklas =?iso-8859-1?Q?S=F6derlund?= , Ramesh Shanmugasundaram , Guennadi Liakhovetski , Maxime Coquelin On Mon, Dec 18, 2017 at 05:53:57PM -0200, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose those into structs, > as the criteria can go directly into the union. > > That makes easier to document it, as we don't need to document > weird senseless structs. > > At drivers, this makes even clearer about the match criteria. > > Acked-by: Sylwester Nawrocki > Signed-off-by: Mauro Carvalho Chehab I'm not sure this is needed but it doesn't break anything either. Feel free to add: Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ailus@iki.fi From mboxrd@z Thu Jan 1 00:00:00 1970 From: sakari.ailus@iki.fi (Sakari Ailus) Date: Tue, 19 Dec 2017 10:27:17 +0200 Subject: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure In-Reply-To: <014b64d13c8b9d516afc3319a9de1a97b2a845de.1513625884.git.mchehab@s-opensource.com> References: <014b64d13c8b9d516afc3319a9de1a97b2a845de.1513625884.git.mchehab@s-opensource.com> Message-ID: <20171219082717.3cs62f2lqaj4ib27@valkosipuli.retiisi.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 18, 2017 at 05:53:57PM -0200, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose those into structs, > as the criteria can go directly into the union. > > That makes easier to document it, as we don't need to document > weird senseless structs. > > At drivers, this makes even clearer about the match criteria. > > Acked-by: Sylwester Nawrocki > Signed-off-by: Mauro Carvalho Chehab I'm not sure this is needed but it doesn't break anything either. Feel free to add: Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ailus at iki.fi