From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935405AbdLSIsU (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 03:48:20 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:52894 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933494AbdLSIsR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 03:48:17 -0500
Date: Tue, 19 Dec 2017 09:48:19 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
        Eric Dumazet <edumazet@google.com>, Tariq Toukan <tariqt@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>,
        Komali Katari <komali@chelsio.com>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Casey Leedom <leedom@chelsio.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered
 over netlink
Message-ID: <20171219084819.GB15010@kroah.com>
References: <20171213232122.5ztmwume5kylh4mz@dtor-ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171213232122.5ztmwume5kylh4mz@dtor-ws>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 13, 2017 at 03:21:22PM -0800, Dmitry Torokhov wrote:
> The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized
> constructing uevent data for delivery over netlink by using the raw
> environment buffer, instead of reconstructing it from individual
> environment pointers. Unfortunately in doing so it broke suppressing
> MODALIAS attribute for KOBJ_UNBIND events, as the code that suppressed this
> attribute only adjusted the environment pointers, but left the buffer
> itself alone. Let's fix it by making sure the offending attribute is
> obliterated form the buffer as well.
> 
> Reported-by: Tariq Toukan <tariqt@mellanox.com>
> Reported-by: Casey Leedom <leedom@chelsio.com>
> Fixes: 4a336a23d619 ("kobject: copy env blob in one go")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  lib/kobject_uevent.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)

Ok, I'm lost here, is this patch still needed for 4.15-final?

And am I supposed to be taking it through my tree as the offending patch
didn't come from me?  :)

thanks,

greg k-h