From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 1/6] ethdev: add devop to check removal
 status
Date: Tue, 19 Dec 2017 09:20:17 -0800
Message-ID: <20171219092017.532d596f@xeon-e3>
References: <1513175370-16583-1-git-send-email-matan@mellanox.com>
 <1513703415-29145-1-git-send-email-matan@mellanox.com>
 <1513703415-29145-2-git-send-email-matan@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon
 <thomas@monjalon.net>, Gaetan Rivet <gaetan.rivet@6wind.com>, dev@dpdk.org
To: Matan Azrad <matan@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f46.google.com (mail-pl0-f46.google.com
 [209.85.160.46]) by dpdk.org (Postfix) with ESMTP id E20CF1B03D
 for <dev@dpdk.org>; Tue, 19 Dec 2017 18:20:20 +0100 (CET)
Received: by mail-pl0-f46.google.com with SMTP id i6so7363167plt.13
 for <dev@dpdk.org>; Tue, 19 Dec 2017 09:20:20 -0800 (PST)
In-Reply-To: <1513703415-29145-2-git-send-email-matan@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 19 Dec 2017 17:10:10 +0000
Matan Azrad <matan@mellanox.com> wrote:

>  int
> +rte_eth_dev_is_removed(uint16_t port_id)
> +{
> +	struct rte_eth_dev *dev;
> +	int ret;
> +
> +	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
> +
> +	dev = &rte_eth_devices[port_id];
> +
> +	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->is_removed, 0);
> +
> +	if (dev->state == RTE_ETH_DEV_REMOVED)
> +		return 1;
> +
> +	ret = dev->dev_ops->is_removed(dev);
> +	if (ret != 0)
> +		dev->state = RTE_ETH_DEV_REMOVED;
> +
> +	return ret;
> +}
> +

This looks good.
May be a candidate to use bool instead of int for return value?