From: kbuild test robot <lkp@intel.com>
To: Ilya Lesokhin <ilyal@mellanox.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org, davem@davemloft.net,
davejwatson@fb.com, tom@herbertland.com,
hannes@stressinduktion.org, borisp@mellanox.com,
aviadye@mellanox.com, liranl@mellanox.com,
Ilya Lesokhin <ilyal@mellanox.com>
Subject: Re: [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure.
Date: Tue, 19 Dec 2017 15:01:51 +0800 [thread overview]
Message-ID: <201712191430.MeDYuciS%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171218111033.13256-7-ilyal@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]
Hi Ilya,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Ilya-Lesokhin/tls-Add-generic-NIC-offload-infrastructure/20171219-140819
config: tile-allmodconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile
All errors (new ones prefixed by >>):
net/tls/tls_device_fallback.c: In function 'update_chksum':
>> net/tls/tls_device_fallback.c:190:16: error: implicit declaration of function 'csum_ipv6_magic'; did you mean 'csum_tcpudp_magic'? [-Werror=implicit-function-declaration]
th->check = ~csum_ipv6_magic(&ipv6h->saddr, &ipv6h->daddr,
^~~~~~~~~~~~~~~
csum_tcpudp_magic
cc1: some warnings being treated as errors
vim +190 net/tls/tls_device_fallback.c
166
167 static inline void update_chksum(struct sk_buff *skb, int headln)
168 {
169 /* Can't use icsk->icsk_af_ops->send_check here because the ip addresses
170 * might have been changed by NAT.
171 */
172
173 const struct ipv6hdr *ipv6h;
174 const struct iphdr *iph;
175 struct tcphdr *th = tcp_hdr(skb);
176 int datalen = skb->len - headln;
177
178 /* We only changed the payload so if we are using partial we don't
179 * need to update anything.
180 */
181 if (likely(skb->ip_summed == CHECKSUM_PARTIAL))
182 return;
183
184 skb->ip_summed = CHECKSUM_PARTIAL;
185 skb->csum_start = skb_transport_header(skb) - skb->head;
186 skb->csum_offset = offsetof(struct tcphdr, check);
187
188 if (skb->sk->sk_family == AF_INET6) {
189 ipv6h = ipv6_hdr(skb);
> 190 th->check = ~csum_ipv6_magic(&ipv6h->saddr, &ipv6h->daddr,
191 datalen, IPPROTO_TCP, 0);
192 } else {
193 iph = ip_hdr(skb);
194 th->check = ~csum_tcpudp_magic(iph->saddr, iph->daddr, datalen,
195 IPPROTO_TCP, 0);
196 }
197 }
198
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51390 bytes --]
next prev parent reply other threads:[~2017-12-19 7:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 11:10 [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 1/6] tcp: Add clean acked data hook Ilya Lesokhin
2017-12-19 19:13 ` Eric Dumazet
2017-12-19 19:21 ` Ilya Lesokhin
2017-12-19 19:28 ` Eric Dumazet
2017-12-19 19:43 ` Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 2/6] net: Rename and export copy_skb_header Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 3/6] net: Add SW fallback infrastructure for offloaded sockets Ilya Lesokhin
2017-12-18 19:18 ` Marcelo Ricardo Leitner
2017-12-19 7:51 ` Ilya Lesokhin
2017-12-19 15:05 ` Marcelo Ricardo Leitner
2017-12-19 19:12 ` Eric Dumazet
2017-12-19 19:15 ` Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 4/6] net: Add TLS offload netdev ops Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 5/6] net: Add TLS TX offload features Ilya Lesokhin
2017-12-18 11:10 ` [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure Ilya Lesokhin
2017-12-18 19:53 ` Marcelo Ricardo Leitner
2017-12-19 7:31 ` Ilya Lesokhin
2017-12-19 15:11 ` Marcelo Ricardo Leitner
2017-12-19 15:38 ` Ilya Lesokhin
2017-12-19 16:18 ` Marcelo Ricardo Leitner
2017-12-19 7:00 ` kbuild test robot
2017-12-19 7:01 ` kbuild test robot [this message]
2017-12-19 8:17 ` [RFC PATCH] tls: tls_sw_fallback() can be static kbuild test robot
2017-12-19 8:17 ` [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure kbuild test robot
2017-12-18 17:10 ` [PATCH v3 net-next 0/6] " Jiri Pirko
2017-12-19 10:30 ` Jiri Pirko
2017-12-20 8:28 ` Boris Pismenny
2017-12-20 10:08 ` Jiri Pirko
2017-12-20 10:15 ` Or Gerlitz
2017-12-20 10:31 ` Or Gerlitz
2017-12-20 16:12 ` David Miller
2017-12-20 16:23 ` Ilya Lesokhin
2017-12-20 16:36 ` David Miller
2017-12-20 19:12 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201712191430.MeDYuciS%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=ilyal@mellanox.com \
--cc=kbuild-all@01.org \
--cc=liranl@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.