From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763624AbdLSOi1 (ORCPT ); Tue, 19 Dec 2017 09:38:27 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:58975 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbdLSOiS (ORCPT ); Tue, 19 Dec 2017 09:38:18 -0500 Date: Tue, 19 Dec 2017 15:38:11 +0100 From: Peter Zijlstra To: Rodrigo Siqueira Cc: Ingo Molnar , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Adjustments: lock/unlock task in context_switch Message-ID: <20171219143811.yooqtut2ugwuq5hx@hirez.programming.kicks-ass.net> References: <20171215140603.gxe5i2y6fg5ojfpp@smtp.gmail.com> <20171218193002.zzuocnd2hyt34ok5@hirez.programming.kicks-ass.net> <20171219142357.cfmdyfyhay4hsxrb@smtp.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171219142357.cfmdyfyhay4hsxrb@smtp.gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 19, 2017 at 12:23:57PM -0200, Rodrigo Siqueira wrote: > In the original patch, I called this function as release_lock_task, > because the release_task was already declared as extern in > include/linux/sched/task.h. I believe there is a function name conflict > here, is that correct? Bah, you're right. Clearly I didn't compile test yet.. I'll fix it up. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Tue, 19 Dec 2017 14:38:11 +0000 Subject: Re: [PATCH v2] Adjustments: lock/unlock task in context_switch Message-Id: <20171219143811.yooqtut2ugwuq5hx@hirez.programming.kicks-ass.net> List-Id: References: <20171215140603.gxe5i2y6fg5ojfpp@smtp.gmail.com> <20171218193002.zzuocnd2hyt34ok5@hirez.programming.kicks-ass.net> <20171219142357.cfmdyfyhay4hsxrb@smtp.gmail.com> In-Reply-To: <20171219142357.cfmdyfyhay4hsxrb@smtp.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Rodrigo Siqueira Cc: Ingo Molnar , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Dec 19, 2017 at 12:23:57PM -0200, Rodrigo Siqueira wrote: > In the original patch, I called this function as release_lock_task, > because the release_task was already declared as extern in > include/linux/sched/task.h. I believe there is a function name conflict > here, is that correct? Bah, you're right. Clearly I didn't compile test yet.. I'll fix it up. Thanks.