From: Chuck Lever <chuck.lever@oracle.com>
To: SteveD@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] mountstats: Use correct RDMA terminology
Date: Tue, 19 Dec 2017 11:35:32 -0500 [thread overview]
Message-ID: <20171219163529.10803.82407.stgit@manet.1015granger.net> (raw)
The kernel is counting RDMA segments, not chunks. Correct the units
labels displayed by "mountstats -x", and fix up the internal names
of the counters.
Fixes: 6742ba53ae79 ("mountstats: Add option to pretty-print ...")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
tools/mountstats/mountstats.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 440aa72..c7fb8bb 100755
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -120,9 +120,9 @@ XprtRdmaCounters = [
'badxids',
'inflightsends',
'backlogutil',
- 'read_chunks',
- 'write_chunks',
- 'reply_chunks',
+ 'read_segments',
+ 'write_segments',
+ 'reply_segments',
'total_rdma_req',
'total_rdma_rep',
'pullup',
@@ -718,9 +718,9 @@ class DeviceData:
if self.__rpc_data['rpcsends'] != 0:
print('\tAvg backlog length: %d' % \
(float(self.__rpc_data['backlogutil']) / self.__rpc_data['rpcsends']))
- print('\tRead chunks: %d' % self.__rpc_data['read_chunks'])
- print('\tWrite chunks: %d' % self.__rpc_data['write_chunks'])
- print('\tReply chunks: %d' % self.__rpc_data['reply_chunks'])
+ print('\tRead segments: %d' % self.__rpc_data['read_segments'])
+ print('\tWrite segments: %d' % self.__rpc_data['write_segments'])
+ print('\tReply segments: %d' % self.__rpc_data['reply_segments'])
print('\tRegistered: %d bytes' % self.__rpc_data['total_rdma_req'])
print('\tRDMA received: %d bytes' % self.__rpc_data['total_rdma_rep'])
print('\tTotal pull-up: %d bytes' % self.__rpc_data['pullup'])
next reply other threads:[~2017-12-19 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 16:35 Chuck Lever [this message]
2017-12-20 15:02 ` [PATCH] mountstats: Use correct RDMA terminology Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219163529.10803.82407.stgit@manet.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.