All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Weiser <michael.weiser@gmx.de>
To: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH v2 5/5] linux-user: Add aarch64_be magic numbers to qemu-binfmt-conf.sh
Date: Wed, 20 Dec 2017 17:15:56 +0100	[thread overview]
Message-ID: <20171220161556.GF15475@weiser.dinsnail.net> (raw)
In-Reply-To: <1d8aa1e1-2160-015a-28f5-58baaa51f728@vivier.eu>

Hi Laurent,

On Wed, Dec 20, 2017 at 04:56:41PM +0100, Laurent Vivier wrote:

> > Based on that I suspect that qemu-binfmt-conf.sh's current assignment of
> > armeb and aarch64 into the arm CPU family is over-optimistic as well.
> > So I'd suggest treating all of arm, armeb, aarch64 and aarch64_be as
> > separate families.
> So it's not like on intel/AMD where we can execute a 32bit binary on a
> 64bit kernel?

An aarch64 CPU is capable of running arm (i.e. aarch32) code. And I
think this is supported as a multilib setup on Linux. But not in mixed
endianess as far as I know.

Looking at the code again, I'm confused now: Wouldn't the current logic
treat an actual i386 machine as capable of running x86_64 binaries
natively and omit registering the handler for x86_64?

> > Incidentally: I noticed that armeb is missing from qemu_target_list. Is
> > that intentional?
> no. please fix it :)

Will do.

> > Okay?
> It looks good to me.

Based on the above I now lean towards the following assignments:

 arm_family=arm
[...]
-armeb_family=arm
+armeb_family=armeb
[...] 
 aarch64_family=arm
[...]
-aarch64_be_family=arm
+aarch64_be_family=armeb

This would be in line with what you recommended, how i386/x86_64 is
treated and reflects the principal platform capabilities.
-- 
Bye,
Michael

  reply	other threads:[~2017-12-20 16:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 20:16 [Qemu-devel] [PATCH v2 0/5] Add aarch64_be-linux-user target Michael Weiser
2017-12-19 20:16 ` [Qemu-devel] [PATCH v2 1/5] linux-user: Add support for big-endian aarch64 Michael Weiser
2017-12-19 20:16 ` [Qemu-devel] [PATCH v2 2/5] linux-user: Add separate aarch64_be uname Michael Weiser
2017-12-20 15:20   ` Laurent Vivier
2017-12-20 15:36     ` Peter Maydell
2017-12-20 15:51       ` Laurent Vivier
2017-12-20 16:01       ` Michael Weiser
2017-12-19 20:16 ` [Qemu-devel] [PATCH v2 3/5] linux-user: Fix endianess of aarch64 signal trampoline Michael Weiser
2017-12-19 20:16 ` [Qemu-devel] [PATCH v2 4/5] configure: Add aarch64_be-linux-user target Michael Weiser
2017-12-20 14:55   ` Laurent Vivier
2017-12-20 15:51     ` Michael Weiser
2017-12-19 20:16 ` [Qemu-devel] [PATCH v2 5/5] linux-user: Add aarch64_be magic numbers to qemu-binfmt-conf.sh Michael Weiser
2017-12-20 14:18   ` Laurent Vivier
2017-12-20 15:37     ` Michael Weiser
2017-12-20 15:56       ` Laurent Vivier
2017-12-20 16:15         ` Michael Weiser [this message]
2017-12-20 16:43           ` Laurent Vivier
2017-12-20 20:29             ` Michael Weiser
2017-12-19 20:45 ` [Qemu-devel] [PATCH v2 0/5] Add aarch64_be-linux-user target no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220161556.GF15475@weiser.dinsnail.net \
    --to=michael.weiser@gmx.de \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.