From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: KVM <kvm@vger.kernel.org>, linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH 1/5] s390x/mm: cleanup gmap_pte_op_walk()
Date: Wed, 20 Dec 2017 17:33:00 +0100 [thread overview]
Message-ID: <20171220173300.6f308f2f.cohuck@redhat.com> (raw)
In-Reply-To: <20171220155300.102321-2-borntraeger@de.ibm.com>
On Wed, 20 Dec 2017 16:52:56 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> From: David Hildenbrand <david@redhat.com>
>
> gmap_mprotect_notify() refuses shadow gmaps. Turns out that
> a) gmap_protect_range()
> b) gmap_read_table()
> c) gmap_pte_op_walk()
>
> Are never called for gmap shadows. And never should be. This dates back
> to gmap shadow prototypes where we allowed to call mprotect_notify() on
> the gmap shadow (to get notified about the prefix pages getting removed).
> This is avoided by always getting notified about any change on the gmap
> shadow.
>
> The only real function for walking page tables on shadow gmaps is
> gmap_table_walk().
>
> So, essentially, these functions should never get called and
> gmap_pte_op_walk() can be cleaned up. Add some checks to callers of
> gmap_pte_op_walk().
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> Message-Id: <20171110151805.7541-1-david@redhat.com>
> Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/mm/gmap.c | 23 ++++++++---------------
> 1 file changed, 8 insertions(+), 15 deletions(-)
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2017-12-20 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 15:52 [PATCH 0/5] preview of first chunk of s390 patches for kvm/next Christian Borntraeger
2017-12-20 15:52 ` [PATCH 1/5] s390x/mm: cleanup gmap_pte_op_walk() Christian Borntraeger
2017-12-20 16:33 ` Cornelia Huck [this message]
2017-12-20 15:52 ` [PATCH 2/5] KVM: s390: use created_vcpus in more places Christian Borntraeger
2017-12-20 16:35 ` Cornelia Huck
2018-01-08 11:08 ` David Hildenbrand
2017-12-20 15:52 ` [PATCH 3/5] KVM: s390: add debug tracing for cpu features of CPU model Christian Borntraeger
2017-12-20 16:37 ` Cornelia Huck
2018-01-08 11:14 ` David Hildenbrand
2017-12-20 15:52 ` [PATCH 4/5] KVM: s390: drop use of spin lock in __floating_irq_kick Christian Borntraeger
2017-12-20 16:40 ` Cornelia Huck
2018-01-08 12:10 ` David Hildenbrand
2017-12-20 15:53 ` [PATCH 5/5] kvm_config: add CONFIG_S390_GUEST Christian Borntraeger
2017-12-20 16:44 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220173300.6f308f2f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.