From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure Date: Wed, 20 Dec 2017 20:12:13 +0100 Message-ID: <20171220191213.GA1760@nanopsycho> References: <20171220.111208.1328340432834146497.davem@davemloft.net> <20171220.113614.1447120146427365359.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ilyal@mellanox.com, borisp@mellanox.com, netdev@vger.kernel.org, davejwatson@fb.com, tom@herbertland.com, hannes@stressinduktion.org, aviadye@mellanox.com, liranl@mellanox.com To: David Miller Return-path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:39452 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756429AbdLTTMP (ORCPT ); Wed, 20 Dec 2017 14:12:15 -0500 Received: by mail-wm0-f47.google.com with SMTP id i11so11687054wmf.4 for ; Wed, 20 Dec 2017 11:12:15 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171220.113614.1447120146427365359.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Dec 20, 2017 at 05:36:14PM CET, davem@davemloft.net wrote: >From: Ilya Lesokhin >Date: Wed, 20 Dec 2017 16:23:03 +0000 > >>> Whether you provide the API addition patches and the user in the same patch >>> series, or a separate one, doesn't really matter. What is important is that this >>> is accessible to the reviewer at the same time. >> >> Note that we did provide a user in an accessible place. > >That is not accessible for people reading netdev, it needs to be posted >on the netdev list. > >It is never appropriate to require a reviewer to look at some external >site to review a patch series posted here. Yeah, that is why I think it is really best to have the infra and the driver that uses it in a single patchset. Easier to understand what is going on :)