From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752875AbdLUQRi (ORCPT ); Thu, 21 Dec 2017 11:17:38 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:46415 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdLUQRd (ORCPT ); Thu, 21 Dec 2017 11:17:33 -0500 X-Google-Smtp-Source: ACJfBouJeYE6V+MBFB9QorJXd0Kf25oXRldNfy1mbOfywGfbDE0ewl5M8BJ/6f4zewl3uEuI51XIEw== Date: Thu, 21 Dec 2017 09:17:28 -0700 From: Jason Gunthorpe To: Alexander.Steffen@infineon.com Cc: chiu@endlessm.com, peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux@endlessm.com Subject: Re: TPM driver breaks S3 suspend Message-ID: <20171221161728.GB20015@ziepe.ca> References: <5dbce6c25e7e499aaac05269ba3c0f73@infineon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5dbce6c25e7e499aaac05269ba3c0f73@infineon.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 21, 2017 at 10:19:09AM +0000, Alexander.Steffen@infineon.com wrote: > The correct solution should be something like tpm2_auto_startup > (execute selftests, if they fail because of the missing startup > command, execute that and retry the selftests). Interestingly, > tpm1_auto_startup (same purpose as tpm2_auto_startup, but for TPM > 1.2 instead) does not use the same sequence, the startup-retry part > is missing. Is there any reason this is done differently for TPM > 1.2? No TPM 1.2 has needed the retry loop so far.. don't see any problem with adding it if the spec supports it. Jason