From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v2 18/18] doc: remove devargs deprecation notices Date: Fri, 22 Dec 2017 09:33:01 +0100 Message-ID: <20171222083301.mhrfefujr2kz4tgk@bidouze.vm.6wind.com> References: <3930fcee-7ff6-c6f9-273b-14c16bef6ab1@nxp.com> <20171213102552.nmrf73y7yvzexkz7@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" To: Shreyansh Jain Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 0C51F1B35C for ; Fri, 22 Dec 2017 09:33:14 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id n138so20268780wmg.2 for ; Fri, 22 Dec 2017 00:33:14 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Shreyansh, On Fri, Dec 22, 2017 at 10:29:14AM +0530, Shreyansh Jain wrote: > Hello Gaetan, > > On Wednesday 13 December 2017 04:24 PM, Shreyansh Jain wrote: > > Hello Gaetan, > > > > > -----Original Message----- > > > From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com] > > > Sent: Wednesday, December 13, 2017 3:56 PM > > > To: Shreyansh Jain > > > Cc: dev@dpdk.org > > > Subject: Re: [PATCH v2 18/18] doc: remove devargs deprecation notices > > > > > [...] > > > While reading through the code, I also had the same feeling - there can be corner cases in the parsing functions which I can't imagine. Anyways, those need to be runtime-verified - static reviews may not suffice. > > > > > > > > I would certainly appreciate if you are able to fix the pci / vdev > > > limitation in rte_eal_dev_attach, as I am starting to be overwhelmed > > > with work (trying to finish a lot of things before the holidays). > > OK. > > Once you give the devargs a push, I will start work on the PCI removal from rte_eal_dev_attach. Before that, I just want to be sure of devargs with non-PCI bus (non hotplug case). > > > > And, thanks for tons of work you are handling. I saw the patches and really appreciate how you have split things up in sequential manner per-patch. It is difficult. > > Have you pushed the new version of the devargs patches? > Just wanted to check in case I have missed it. > No sorry, I am removing the dependency on the bus control framework from the devargs patchset. I finished the patchset otherwise (redid the unit test), but after some thinking I found that the bus control was maybe not ideal. I will send the devargs patchset soon, once it is made independent, and will expose the issue with the bus control. Best, -- Gaëtan Rivet 6WIND