From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756805AbdLVSda (ORCPT ); Fri, 22 Dec 2017 13:33:30 -0500 Received: from mga09.intel.com ([134.134.136.24]:32041 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756218AbdLVSd3 (ORCPT ); Fri, 22 Dec 2017 13:33:29 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,442,1508828400"; d="scan'208";a="189082819" Date: Fri, 22 Dec 2017 20:33:24 +0200 From: Jarkko Sakkinen To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, James Ettle , Hans de Goede , Azhar Shaikh , Arnd Bergmann , Peter Huewe , Jason Gunthorpe , Greg Kroah-Hartman , linux-integrity@vger.kernel.org Subject: Re: [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag Message-ID: <20171222183324.hqav6npybepqn5tz@linux.intel.com> References: <20171220113538.16099-1-javierm@redhat.com> <20171220113538.16099-3-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171220113538.16099-3-javierm@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 20, 2017 at 12:35:36PM +0100, Javier Martinez Canillas wrote: > This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell > systems, but the only way this can happen is if the code is not correct. > > So it's an unnecessary check that just makes the code harder to read. > > Suggested-by: Jarkko Sakkinen > Signed-off-by: Javier Martinez Canillas Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen /Jarkko