From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751320AbdLWFvu (ORCPT ); Sat, 23 Dec 2017 00:51:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:42900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbdLWFvt (ORCPT ); Sat, 23 Dec 2017 00:51:49 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2C47218EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Sat, 23 Dec 2017 00:51:45 -0500 From: Steven Rostedt To: Josh Poimboeuf Cc: LKML , Ingo Molnar , Thomas Gleixner , Andrew Morton , x86@kernel.org, Linus Torvalds Subject: Re: [RFC][PATCH][REGRESSION FIX] x86/ftrace: Add ORC annotation to 64 bit ftrace assembly Message-ID: <20171223005145.5f4d3884@gandalf.local.home> In-Reply-To: <20171223024337.e6ad3gqldiju7ndl@treble> References: <20171222131841.4564c975@gandalf.local.home> <20171222183024.47yadfkznhwhrlgf@treble> <20171222133801.3c9b1078@gandalf.local.home> <20171223024337.e6ad3gqldiju7ndl@treble> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Dec 2017 20:43:37 -0600 Josh Poimboeuf wrote: > Objtool doesn't like the fact that save_mcount_regs pushes rbp at the > beginning, but it's never restored (directly, at least). > > How about something like this instead, where it skips the original rbp > push? I didn't test it, but I think it should work. It at least gets > rid of the warnings and doesn't need any unwind hints other than the > UNWIND_HINT_EMPTY in return_to_handler. There's a reason I did it that way, but don't remember exactly why. I think we discussed this a while ago when we had issues with ftrace.S during your first iterations of objtool. I'll have to test all different compile options and different gcc compiler versions. -- Steve