All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH rdma-next 8/8] RDMA/cma: Mark end of CMA ID messages
Date: Sun, 24 Dec 2017 15:43:28 +0200	[thread overview]
Message-ID: <20171224134328.17398-9-leon@kernel.org> (raw)
In-Reply-To: <20171224134328.17398-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

The commit 1a1c116f3dcf ("RDMA/netlink: Simplify the put_msg and
put_attr") removes nlmsg_len calculation in ibnl_put_attr causing
netlink messages and caused to miss source and destination addresses.

Fixes: 1a1c116f3dcf ("RDMA/netlink: Simplify the put_msg and put_attr")
Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/core/cma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index e5c9f42a7e4b..209373159dd7 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4439,6 +4439,7 @@ static int cma_get_id_stats(struct sk_buff *skb, struct netlink_callback *cb)
 			id_stats->qp_type	= id->qp_type;

 			i_id++;
+			nlmsg_end(skb, nlh);
 		}

 		cb->args[1] = 0;
--
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-12-24 13:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-24 13:43 [PATCH rdma-next 0/8] RDMA fixes and refactoring rdma-next-2017-12-24 Leon Romanovsky
     [not found] ` <20171224134328.17398-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-12-24 13:43   ` [PATCH rdma-next 1/8] RDMA/rxe: Remove useless export symbol Leon Romanovsky
2017-12-24 13:43   ` [PATCH rdma-next 2/8] RDMA/netlink: Simplify code of autoload modules Leon Romanovsky
2017-12-24 13:43   ` [PATCH rdma-next 3/8] RDMA/core: Replace open-coded variant of put_device Leon Romanovsky
2017-12-24 13:43   ` [PATCH rdma-next 4/8] RDMA/nldev: Refactor nldev handle to be common function Leon Romanovsky
2017-12-24 13:43   ` [PATCH rdma-next 5/8] RDMA/core: Provide locked variant of device name to index function Leon Romanovsky
     [not found]     ` <20171224134328.17398-6-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-12-27 23:02       ` Jason Gunthorpe
     [not found]         ` <20171227230227.GK25436-uk2M96/98Pc@public.gmane.org>
2017-12-28  5:01           ` Leon Romanovsky
2017-12-24 13:43   ` [PATCH rdma-next 6/8] RDMA/netlink: Protect device query from device removal Leon Romanovsky
     [not found]     ` <20171224134328.17398-7-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-12-27 23:05       ` Jason Gunthorpe
     [not found]         ` <20171227230552.GL25436-uk2M96/98Pc@public.gmane.org>
2017-12-28  5:04           ` Leon Romanovsky
2017-12-24 13:43   ` [PATCH rdma-next 7/8] RDMA/nldev: Protect port query from accidental " Leon Romanovsky
2017-12-24 13:43   ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171224134328.17398-9-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.