From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUQnk-00006q-4N for qemu-devel@nongnu.org; Thu, 28 Dec 2017 00:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUQnj-0004Yo-Fj for qemu-devel@nongnu.org; Thu, 28 Dec 2017 00:32:20 -0500 Date: Thu, 28 Dec 2017 13:32:03 +0800 From: Fam Zheng Message-ID: <20171228053203.GD9192@lemon> References: <20171220154945.88410-1-vsementsov@virtuozzo.com> <20171220154945.88410-5-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171220154945.88410-5-vsementsov@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com, peter.maydell@linaro.org, lirans@il.ibm.com, quintela@redhat.com, jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com On Wed, 12/20 18:49, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index fe27ddfb83..6218740c95 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -40,6 +40,8 @@ struct BdrvDirtyBitmap { > QemuMutex *mutex; > HBitmap *bitmap; /* Dirty bitmap implementation */ > HBitmap *meta; /* Meta dirty bitmap */ > + bool qmp_locked; /* Bitmap is frozen, it can't be modified > + through QMP */ Please fix the alignment when you respin. Thanks. Fam