From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eURlD-0006c4-UY for qemu-devel@nongnu.org; Thu, 28 Dec 2017 01:33:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eURlC-0007p1-LI for qemu-devel@nongnu.org; Thu, 28 Dec 2017 01:33:47 -0500 Date: Thu, 28 Dec 2017 14:33:30 +0800 From: Fam Zheng Message-ID: <20171228063330.GL9192@lemon> References: <20171220154945.88410-1-vsementsov@virtuozzo.com> <20171220154945.88410-14-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171220154945.88410-14-vsementsov@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com, peter.maydell@linaro.org, lirans@il.ibm.com, quintela@redhat.com, jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com On Wed, 12/20 18:49, Vladimir Sementsov-Ogievskiy wrote: > Test > - start two vms (vm_a, vm_b) > > - in a > - do writes from set A > - do writes from set B > - fix bitmap sha256 > - clear bitmap > - do writes from set A > - start migration > - than, in b > - wait vm start (postcopy should start) > - do writes from set B > - check bitmap sha256 > > The test should verify postcopy migration and then merging with delta > (changes in target, during postcopy process). > > Reduce supported cache modes to only 'none', because with cache on time > from source.STOP to target.RESUME is unpredictable and we can fail with > timout while waiting for target.RESUME. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/199 | 105 ++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/199.out | 5 ++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 7 ++- > 4 files changed, 117 insertions(+), 1 deletion(-) > create mode 100755 tests/qemu-iotests/199 > create mode 100644 tests/qemu-iotests/199.out > > diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/199 > new file mode 100755 > index 0000000000..f872040a81 > --- /dev/null > +++ b/tests/qemu-iotests/199 > @@ -0,0 +1,105 @@ > +#!/usr/bin/env python > +# > +# Tests for dirty bitmaps postcopy migration. > +# > +# Copyright (c) 2016-2017 Virtuozzo International GmbH. All rights reserved. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > +# > + > +import os > +import iotests > +import time > +from iotests import qemu_img > + > +disk_a = os.path.join(iotests.test_dir, 'disk_a') > +disk_b = os.path.join(iotests.test_dir, 'disk_b') > +size = '256G' > +fifo = os.path.join(iotests.test_dir, 'mig_fifo') > + > +class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase): > + > + def tearDown(self): > + self.vm_a.shutdown() > + self.vm_b.shutdown() > + os.remove(disk_a) > + os.remove(disk_b) > + os.remove(fifo) > + > + def setUp(self): > + os.mkfifo(fifo) > + qemu_img('create', '-f', iotests.imgfmt, disk_a, size) > + qemu_img('create', '-f', iotests.imgfmt, disk_b, size) > + self.vm_a = iotests.VM(path_suffix='a').add_drive(disk_a) > + self.vm_b = iotests.VM(path_suffix='b').add_drive(disk_b) > + self.vm_b.add_incoming("exec: cat '" + fifo + "'") > + self.vm_a.launch() > + self.vm_b.launch() > + > + def test_postcopy(self): > + write_size = 0x40000000 > + granularity = 512 > + chunk = 4096 > + > + result = self.vm_a.qmp('block-dirty-bitmap-add', node='drive0', > + name='bitmap', granularity=granularity) > + self.assert_qmp(result, 'return', {}); > + > + s = 0 > + while s < write_size: > + self.vm_a.hmp_qemu_io('drive0', 'write %d %d' % (s, chunk)) > + s += 0x10000 > + s = 0x8000 > + while s < write_size: > + self.vm_a.hmp_qemu_io('drive0', 'write %d %d' % (s, chunk)) > + s += 0x10000 > + > + result = self.vm_a.qmp('x-debug-block-dirty-bitmap-sha256', > + node='drive0', name='bitmap') > + sha256 = result['return']['sha256'] > + > + result = self.vm_a.qmp('block-dirty-bitmap-clear', node='drive0', > + name='bitmap') > + self.assert_qmp(result, 'return', {}); > + s = 0 > + while s < write_size: > + self.vm_a.hmp_qemu_io('drive0', 'write %d %d' % (s, chunk)) > + s += 0x10000 > + > + result = self.vm_a.qmp('migrate-set-capabilities', > + capabilities=[{'capability': 'dirty-bitmaps', > + 'state': True}]) > + self.assert_qmp(result, 'return', {}) > + > + result = self.vm_a.qmp('migrate', uri='exec:cat>' + fifo) > + self.assertNotEqual(self.vm_a.event_wait("STOP"), None) > + self.assertNotEqual(self.vm_b.event_wait("RESUME"), None) > + > + s = 0x8000 > + while s < write_size: > + self.vm_b.hmp_qemu_io('drive0', 'write %d %d' % (s, chunk)) > + s += 0x10000 > + > + result = self.vm_b.qmp('query-block'); > + while len(result['return'][0]['dirty-bitmaps']) > 1: > + time.sleep(2) > + result = self.vm_b.qmp('query-block'); > + > + result = self.vm_b.qmp('x-debug-block-dirty-bitmap-sha256', > + node='drive0', name='bitmap') > + > + self.assert_qmp(result, 'return/sha256', sha256); > + Reviewed-by: Fam Zheng