From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 1/2] gro: code cleanup
Date: Tue, 2 Jan 2018 11:26:01 +0000
Message-ID: <20180102112600.GA10276@bricha3-MOBL3.ger.corp.intel.com>
References: <1513219779-100115-1-git-send-email-jiayu.hu@intel.com>
 <1513927544-97241-1-git-send-email-jiayu.hu@intel.com>
 <1513927544-97241-2-git-send-email-jiayu.hu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, jianfeng.tan@intel.com, junjie.j.chen@intel.com,
 konstantin.ananyev@intel.com, stephen@networkplumber.org,
 ferruh.yigit@intel.com, lei.a.yao@intel.com
To: Jiayu Hu <jiayu.hu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7388D7D30
 for <dev@dpdk.org>; Tue,  2 Jan 2018 12:26:07 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1513927544-97241-2-git-send-email-jiayu.hu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Dec 22, 2017 at 03:25:43PM +0800, Jiayu Hu wrote:
> - Remove needless check and variants
> - For better understanding, update the programmer guide and rename
>   internal functions and variants
> - For supporting tunneled gro, move common internal functions from
>   gro_tcp4.c to gro_tcp4.h
> - Comply RFC 6864 to process the IPv4 ID field
> 
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
>  .../prog_guide/generic_receive_offload_lib.rst     | 246 ++++++++-------
>  doc/guides/prog_guide/img/gro-key-algorithm.png    | Bin 0 -> 28231 bytes

Rather than binary PNG images, please use SVG files (note, real SVG, not
an SVG file with a binary blob pasted into it).

Thanks,
/Bruce