From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances Date: Thu, 04 Jan 2018 10:33:48 -0500 (EST) Message-ID: <20180104.103348.607053530850783354.davem@davemloft.net> References: <20180104065702.GH2067@nanopsycho.orion> <20180103230658.595eac7d@cakuba.netronome.com> <20180104101257.GA2213@nanopsycho> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kubakici@wp.pl, dsahern@gmail.com, netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:47022 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbeADPdw (ORCPT ); Thu, 4 Jan 2018 10:33:52 -0500 In-Reply-To: <20180104101257.GA2213@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Thu, 4 Jan 2018 11:12:57 +0100 > No magic. ens8 and ens7 share the same block. No Jiri, the fact that they share the same block _IS MAGIC_. It is unexpected behavior to modify a rule and have it propagate to devices not mentioned in the command line. This is totally going to break things and upset people. Saying it shows up in some tc dump command is not an argument for this behavior being "expected". NO way. I completely agree with David and others, you _MUST_ make an explicit API and set of operations to make changes to rules contained in shared blocks. Period.