From: Mark Brown <broonie@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
liam.r.girdwood@linux.intel.com, vinod.koul@intel.com,
Bard Liao <bardliao@realtek.com>
Subject: Re: [PATCH] ASoC: rt5645: add fallback case for jack detection support
Date: Thu, 4 Jan 2018 11:59:19 +0000 [thread overview]
Message-ID: <20180104115918.GB10774@sirena.org.uk> (raw)
In-Reply-To: <6b845088-9900-789c-1137-811321e23252@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 528 bytes --]
On Wed, Jan 03, 2018 at 11:20:38PM +0100, Hans de Goede wrote:
> > + else if (rt5645_check_dp(&i2c->dev))
> > rt5645_parse_dt(rt5645, &i2c->dev);
> > + else
> > + rt5645->pdata = jd_mode3_platform_data;
> How about:
> rt5645->pdata.jd_mode = 3;
> instead and remove jd_mode3_platform_data and the 2 dmi table entries
> pointing to it ?
I'm not sure it's best practice to remove the entries that have been
explicitly added; on the other hand if the default is jd_mode = 3 then
it's not like we'll be adding any more.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-01-04 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 18:42 [PATCH] ASoC: rt5645: add fallback case for jack detection support Pierre-Louis Bossart
2018-01-03 22:20 ` Hans de Goede
2018-01-04 11:59 ` Mark Brown [this message]
2018-01-04 15:15 ` Pierre-Louis Bossart
2018-01-12 12:28 ` Applied "ASoC: rt5645: add fallback case for jack detection support" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104115918.GB10774@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.