From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances Date: Thu, 4 Jan 2018 15:06:53 +0100 Message-ID: <20180104140653.GF2213@nanopsycho> References: <20180103094025.GA2067@nanopsycho.orion> <20180103172209.GD2067@nanopsycho.orion> <20180103155152.7e94a295@cakuba.netronome.com> <20180104065702.GH2067@nanopsycho.orion> <20180103230658.595eac7d@cakuba.netronome.com> <20180104101257.GA2213@nanopsycho> <5163c8db-8b2c-0746-b148-28a7e0fec2c4@mojatatu.com> <20180104130506.GD2213@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jakub Kicinski , David Ahern , netdev@vger.kernel.org, davem@davemloft.net, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: Jamal Hadi Salim Return-path: Received: from mail-wm0-f46.google.com ([74.125.82.46]:36633 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753049AbeADOGz (ORCPT ); Thu, 4 Jan 2018 09:06:55 -0500 Received: by mail-wm0-f46.google.com with SMTP id b76so3673623wmg.1 for ; Thu, 04 Jan 2018 06:06:55 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Thu, Jan 04, 2018 at 02:43:08PM CET, jhs@mojatatu.com wrote: >On 18-01-04 08:05 AM, Jiri Pirko wrote: >> Thu, Jan 04, 2018 at 01:55:05PM CET, jhs@mojatatu.com wrote: > >> > >> > $ tc filter add block 1 protocol ip priority 10 flower ... >> > classid 1:2 >> > >> > Looks good - things will work fine for packets showing >> > up on egress of enps7 which match the flower rule >> > and classid 1:2 is selected to queue the packet on. >> > >> > Things will not _work fine_ for packets showing up on >> > egress of ensp8. There is no classid 1:2 on egress of >> > enps8. The prio qdisc is a bad example because it >> > has a default queue (i think 10:2) in this case. Other >> > qdiscs(off top of my head DRR) will just drop the packet. >> >> I'm very well aware of this. The plan is to support this and resolve >> the lack of classid withing the qdisc according to the qdisc type. > >If i understood you correctly, that is still iffy. >An admin will see packets for the same filter on one device going >to an agreed-to queue but on another going to a default queue. Yeah, it is. That needs a bit more thoughts and discussion. That was the main purpose I did not address it in this patchset and allowed only ingress and clsact qidsc. > >> However, currently the classfull qdiscs are not supported for >> block sharing - only ingress and clsact qdiscs are supported. >> > >Essentially anything that doesnt have queues associated with it.. >(and ignore the tcf_result). > >> > >> > I think this is resolvable - but it will take more to the >> > patches than the current set you posted Jiri. >> > A simple solution is to say sharing only works for ingress >> > (but that sounds very lame). >> >> That is the current limitation of the patchset as you can see. The >> sharing works only for ingress and clsact qdisc. So works for both >> ingress and egress (clsact). >> > >One option is to name all egress queues the same way on all devices >f.e in the two examples i provided call root qdiscs 1:0. > >I am not sure how cleanly you get this to work with egress >My current thinking involves some brain somersault... >I will think some more about it... clsact egress works the same as ingress qdisc - please check the code. > >cheers, >jamal