From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: [PATCH v4 01/19] arm64: asm-offsets: Avoid clashing DMA definitions Date: Thu, 4 Jan 2018 18:43:16 +0000 Message-ID: <20180104184334.16571-2-marc.zyngier@arm.com> References: <20180104184334.16571-1-marc.zyngier@arm.com> Cc: Christoffer Dall , Mark Rutland , Catalin Marinas , Will Deacon , James Morse , Steve Capper , Peter Maydell To: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Return-path: Received: from foss.arm.com ([217.140.101.70]:36584 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbeADSnw (ORCPT ); Thu, 4 Jan 2018 13:43:52 -0500 In-Reply-To: <20180104184334.16571-1-marc.zyngier@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: asm-offsets.h contains a few DMA related definitions that have the exact same name than the enum members they are derived from. While this is not a problem so far, it will become an issue if both asm-offsets.h and include/linux/dma-direction.h: are pulled by the same file. Let's sidestep the issue by renaming the asm-offsets.h constants. Signed-off-by: Marc Zyngier --- arch/arm64/kernel/asm-offsets.c | 6 +++--- arch/arm64/mm/cache.S | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c index 71bf088f1e4b..7e8be0c22ce0 100644 --- a/arch/arm64/kernel/asm-offsets.c +++ b/arch/arm64/kernel/asm-offsets.c @@ -87,9 +87,9 @@ int main(void) BLANK(); DEFINE(PAGE_SZ, PAGE_SIZE); BLANK(); - DEFINE(DMA_BIDIRECTIONAL, DMA_BIDIRECTIONAL); - DEFINE(DMA_TO_DEVICE, DMA_TO_DEVICE); - DEFINE(DMA_FROM_DEVICE, DMA_FROM_DEVICE); + DEFINE(__DMA_BIDIRECTIONAL, DMA_BIDIRECTIONAL); + DEFINE(__DMA_TO_DEVICE, DMA_TO_DEVICE); + DEFINE(__DMA_FROM_DEVICE, DMA_FROM_DEVICE); BLANK(); DEFINE(CLOCK_REALTIME, CLOCK_REALTIME); DEFINE(CLOCK_MONOTONIC, CLOCK_MONOTONIC); diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S index 7f1dbe962cf5..c1336be085eb 100644 --- a/arch/arm64/mm/cache.S +++ b/arch/arm64/mm/cache.S @@ -205,7 +205,7 @@ ENDPIPROC(__dma_flush_area) * - dir - DMA direction */ ENTRY(__dma_map_area) - cmp w2, #DMA_FROM_DEVICE + cmp w2, #__DMA_FROM_DEVICE b.eq __dma_inv_area b __dma_clean_area ENDPIPROC(__dma_map_area) @@ -217,7 +217,7 @@ ENDPIPROC(__dma_map_area) * - dir - DMA direction */ ENTRY(__dma_unmap_area) - cmp w2, #DMA_TO_DEVICE + cmp w2, #__DMA_TO_DEVICE b.ne __dma_inv_area ret ENDPIPROC(__dma_unmap_area) -- 2.14.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Thu, 4 Jan 2018 18:43:16 +0000 Subject: [PATCH v4 01/19] arm64: asm-offsets: Avoid clashing DMA definitions In-Reply-To: <20180104184334.16571-1-marc.zyngier@arm.com> References: <20180104184334.16571-1-marc.zyngier@arm.com> Message-ID: <20180104184334.16571-2-marc.zyngier@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org asm-offsets.h contains a few DMA related definitions that have the exact same name than the enum members they are derived from. While this is not a problem so far, it will become an issue if both asm-offsets.h and include/linux/dma-direction.h: are pulled by the same file. Let's sidestep the issue by renaming the asm-offsets.h constants. Signed-off-by: Marc Zyngier --- arch/arm64/kernel/asm-offsets.c | 6 +++--- arch/arm64/mm/cache.S | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c index 71bf088f1e4b..7e8be0c22ce0 100644 --- a/arch/arm64/kernel/asm-offsets.c +++ b/arch/arm64/kernel/asm-offsets.c @@ -87,9 +87,9 @@ int main(void) BLANK(); DEFINE(PAGE_SZ, PAGE_SIZE); BLANK(); - DEFINE(DMA_BIDIRECTIONAL, DMA_BIDIRECTIONAL); - DEFINE(DMA_TO_DEVICE, DMA_TO_DEVICE); - DEFINE(DMA_FROM_DEVICE, DMA_FROM_DEVICE); + DEFINE(__DMA_BIDIRECTIONAL, DMA_BIDIRECTIONAL); + DEFINE(__DMA_TO_DEVICE, DMA_TO_DEVICE); + DEFINE(__DMA_FROM_DEVICE, DMA_FROM_DEVICE); BLANK(); DEFINE(CLOCK_REALTIME, CLOCK_REALTIME); DEFINE(CLOCK_MONOTONIC, CLOCK_MONOTONIC); diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S index 7f1dbe962cf5..c1336be085eb 100644 --- a/arch/arm64/mm/cache.S +++ b/arch/arm64/mm/cache.S @@ -205,7 +205,7 @@ ENDPIPROC(__dma_flush_area) * - dir - DMA direction */ ENTRY(__dma_map_area) - cmp w2, #DMA_FROM_DEVICE + cmp w2, #__DMA_FROM_DEVICE b.eq __dma_inv_area b __dma_clean_area ENDPIPROC(__dma_map_area) @@ -217,7 +217,7 @@ ENDPIPROC(__dma_map_area) * - dir - DMA direction */ ENTRY(__dma_unmap_area) - cmp w2, #DMA_TO_DEVICE + cmp w2, #__DMA_TO_DEVICE b.ne __dma_inv_area ret ENDPIPROC(__dma_unmap_area) -- 2.14.2