From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 16/16] net/axgbe: add support for build
 32-bit mode
Date: Fri, 5 Jan 2018 12:32:21 -0800
Message-ID: <20180105123221.375aa4fb@xeon-e3>
References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com>
 <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com>
 <1515145938-97474-16-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Ravi Kumar <Ravi1.kumar@amd.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
 [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id DD61E1B00C
 for <dev@dpdk.org>; Fri,  5 Jan 2018 21:32:23 +0100 (CET)
Received: by mail-pf0-f193.google.com with SMTP id p84so2630554pfd.3
 for <dev@dpdk.org>; Fri, 05 Jan 2018 12:32:23 -0800 (PST)
In-Reply-To: <1515145938-97474-16-git-send-email-Ravi1.kumar@amd.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri,  5 Jan 2018 04:52:18 -0500
Ravi Kumar <Ravi1.kumar@amd.com> wrote:

> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> ---
>  doc/guides/nics/features/axgbe.ini |  1 +
>  drivers/net/axgbe/axgbe_common.h   | 49 ++++++++++++++++++++++----------------
>  drivers/net/axgbe/axgbe_ethdev.c   | 10 ++++----
>  drivers/net/axgbe/axgbe_ethdev.h   |  8 +++----
>  drivers/net/axgbe/axgbe_rxtx.c     | 12 +++++-----
>  drivers/net/axgbe/axgbe_rxtx.h     |  4 ++--
>  6 files changed, 48 insertions(+), 36 deletions(-)
> 
> diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini
> index 042ff1e..ab4da55 100644
> --- a/doc/guides/nics/features/axgbe.ini
> +++ b/doc/guides/nics/features/axgbe.ini
> @@ -15,4 +15,5 @@ L3 checksum offload  = Y
>  L4 checksum offload  = Y
>  Basic stats          = Y
>  Linux UIO            = Y
> +x86-32               = Y
>  x86-64               = Y
> diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h
> index 294f2e4..78a055d 100644
> --- a/drivers/net/axgbe/axgbe_common.h
> +++ b/drivers/net/axgbe/axgbe_common.h
> @@ -1507,7 +1507,7 @@ do {									\
>   *  register definitions formed using the input names
>   */
>  #define AXGMAC_IOREAD(_pdata, _reg)					\
> -	rte_read32((void *)((_pdata)->xgmac_regs + (_reg)))
> +	rte_read32((void *)((uint8_t *)((_pdata)->xgmac_regs) + (_reg)))
>  

Since rte_read32 is defined to take void * the cast should not be necessary..
Also in theory _pdata could be const here.