From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752549AbeAEQpP (ORCPT + 1 other); Fri, 5 Jan 2018 11:45:15 -0500 Received: from mx2.suse.de ([195.135.220.15]:38171 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752383AbeAEQpM (ORCPT ); Fri, 5 Jan 2018 11:45:12 -0500 Date: Fri, 5 Jan 2018 17:45:06 +0100 From: Borislav Petkov To: "Woodhouse, David" Cc: "tglx@linutronix.de" , "linux-kernel@vger.kernel.org" , "tim.c.chen@linux.intel.com" , "peterz@infradead.org" , "torvalds@linux-foundation.org" , "ak@linux.intel.com" , "riel@redhat.com" , "keescook@google.com" , "gnomes@lxorguk.ukuu.org.uk" , "pjt@google.com" , "dave.hansen@intel.com" , "luto@amacapital.net" , "jikos@kernel.org" , "gregkh@linux-foundation.org" Subject: Re: [PATCH v3 01/13] x86/retpoline: Add initial retpoline support Message-ID: <20180105164505.xpw5pefxsyu3z56e@pd.tnic> References: <1515058213.12987.89.camel@amazon.co.uk> <20180104143710.8961-1-dwmw@amazon.co.uk> <1515160619.29312.126.camel@amazon.co.uk> <1515170506.29312.149.camel@amazon.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515170506.29312.149.camel@amazon.co.uk> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 05, 2018 at 04:41:46PM +0000, Woodhouse, David wrote: > Nope, alternatives are broken. Only a jmp as the *first* opcode of > altinstr gets handled by recompute_jump(), while any subsequent insn is > just copied untouched. Not broken - simply no one needed it until now. I'm looking into it. Looks like the insn decoder might come in handy finally. :-) -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --