From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755946AbeAHIdD (ORCPT + 1 other); Mon, 8 Jan 2018 03:33:03 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33274 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755009AbeAHIdC (ORCPT ); Mon, 8 Jan 2018 03:33:02 -0500 Date: Mon, 8 Jan 2018 09:33:06 +0100 From: Greg Kroah-Hartman To: Mike Galbraith Cc: Michal Hocko , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Kirill A. Shutemov" , Andrew Morton , Andy Lutomirski , Borislav Petkov , Cyrill Gorcunov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , linux-mm@kvack.org, Ingo Molnar Subject: Re: [PATCH 4.14 023/159] mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y Message-ID: <20180108083306.GA12893@kroah.com> References: <20171222084623.668990192@linuxfoundation.org> <20171222084625.007160464@linuxfoundation.org> <1515302062.6507.18.camel@gmx.de> <20180107091115.GB29329@kroah.com> <20180107101847.GC24862@dhcp22.suse.cz> <1515329042.13953.14.camel@gmx.de> <20180107132309.GD24862@dhcp22.suse.cz> <20180108075308.GC24062@kroah.com> <1515399333.20268.23.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515399333.20268.23.camel@gmx.de> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 09:15:33AM +0100, Mike Galbraith wrote: > On Mon, 2018-01-08 at 08:53 +0100, Greg Kroah-Hartman wrote: > > On Sun, Jan 07, 2018 at 02:23:09PM +0100, Michal Hocko wrote: > > > On Sun 07-01-18 13:44:02, Mike Galbraith wrote: > > > > On Sun, 2018-01-07 at 11:18 +0100, Michal Hocko wrote: > > > > > On Sun 07-01-18 10:11:15, Greg KH wrote: > > > > > > On Sun, Jan 07, 2018 at 06:14:22AM +0100, Mike Galbraith wrote: > > > > > > > On Fri, 2017-12-22 at 09:45 +0100, Greg Kroah-Hartman wrote: > > > > > > > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > > > FYI, this broke kdump, or rather the makedumpfile part thereof. > > > > > > >  Forward looking wreckage is par for the kdump course, but... > > > > > > > > > > > > Is it also broken in Linus's tree with this patch? Or is there an > > > > > > add-on patch that I should apply to 4.14 to resolve this issue there? > > > > > > > > > > This one http://lkml.kernel.org/r/1513932498-20350-1-git-send-email-bhe@redhat.com > > > > > I guess. > > > > > > > > That won't unbreak kdump, else master wouldn't be broken.  I don't care > > > > deeply, or know if anyone else does, I'm just reporting it because I > > > > met it and chased it down. > > > > > > OK, I didn't notice that d8cfbbfa0f7 ("mm/sparse.c: wrong allocation > > > for mem_section") made it in after rc6. I am still wondering why > > > 83e3c48729 ("mm/sparsemem: Allocate mem_section at runtime for > > > CONFIG_SPARSEMEM_EXTREME=y") made it into the stable tree in the first > > > place. > > > > It was part of the prep for the KTPI code from what I can tell. If you > > think it should be reverted, just let me know and I'll be glad to do so. > > No preference here.  I have to patch master regardless if I want kdump > to work while I patiently wait for userspace to get fixed up (either > that or use time I don't have to go fix it up myself). I'll stay "bug compatible" for the time being. If you do fix this up, can you add a cc: stable tag in your patch so I can pick it up when it gets merged? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 8 Jan 2018 09:33:06 +0100 From: Greg Kroah-Hartman To: Mike Galbraith Cc: Michal Hocko , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Kirill A. Shutemov" , Andrew Morton , Andy Lutomirski , Borislav Petkov , Cyrill Gorcunov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , linux-mm@kvack.org, Ingo Molnar Subject: Re: [PATCH 4.14 023/159] mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y Message-ID: <20180108083306.GA12893@kroah.com> References: <20171222084623.668990192@linuxfoundation.org> <20171222084625.007160464@linuxfoundation.org> <1515302062.6507.18.camel@gmx.de> <20180107091115.GB29329@kroah.com> <20180107101847.GC24862@dhcp22.suse.cz> <1515329042.13953.14.camel@gmx.de> <20180107132309.GD24862@dhcp22.suse.cz> <20180108075308.GC24062@kroah.com> <1515399333.20268.23.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515399333.20268.23.camel@gmx.de> Sender: owner-linux-mm@kvack.org List-ID: On Mon, Jan 08, 2018 at 09:15:33AM +0100, Mike Galbraith wrote: > On Mon, 2018-01-08 at 08:53 +0100, Greg Kroah-Hartman wrote: > > On Sun, Jan 07, 2018 at 02:23:09PM +0100, Michal Hocko wrote: > > > On Sun 07-01-18 13:44:02, Mike Galbraith wrote: > > > > On Sun, 2018-01-07 at 11:18 +0100, Michal Hocko wrote: > > > > > On Sun 07-01-18 10:11:15, Greg KH wrote: > > > > > > On Sun, Jan 07, 2018 at 06:14:22AM +0100, Mike Galbraith wrote: > > > > > > > On Fri, 2017-12-22 at 09:45 +0100, Greg Kroah-Hartman wrote: > > > > > > > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > > > FYI, this broke kdump, or rather the makedumpfile part thereof. > > > > > > > �Forward looking wreckage is par for the kdump course, but... > > > > > > > > > > > > Is it also broken in Linus's tree with this patch? Or is there an > > > > > > add-on patch that I should apply to 4.14 to resolve this issue there? > > > > > > > > > > This one http://lkml.kernel.org/r/1513932498-20350-1-git-send-email-bhe@redhat.com > > > > > I guess. > > > > > > > > That won't unbreak kdump, else master wouldn't be broken. �I don't care > > > > deeply, or know if anyone else does, I'm just reporting it because I > > > > met it and chased it down. > > > > > > OK, I didn't notice that d8cfbbfa0f7 ("mm/sparse.c: wrong allocation > > > for mem_section") made it in after rc6. I am still wondering why > > > 83e3c48729 ("mm/sparsemem: Allocate mem_section at runtime for > > > CONFIG_SPARSEMEM_EXTREME=y") made it into the stable tree in the first > > > place. > > > > It was part of the prep for the KTPI code from what I can tell. If you > > think it should be reverted, just let me know and I'll be glad to do so. > > No preference here. �I have to patch master regardless if I want kdump > to work while I patiently wait for userspace to get fixed up (either > that or use time I don't have to go fix it up myself). I'll stay "bug compatible" for the time being. If you do fix this up, can you add a cc: stable tag in your patch so I can pick it up when it gets merged? thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id C35BE6B0284 for ; Mon, 8 Jan 2018 03:33:04 -0500 (EST) Received: by mail-wm0-f70.google.com with SMTP id k126so3869829wmd.5 for ; Mon, 08 Jan 2018 00:33:04 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id j16si7664714wme.109.2018.01.08.00.33.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jan 2018 00:33:03 -0800 (PST) Date: Mon, 8 Jan 2018 09:33:06 +0100 From: Greg Kroah-Hartman Subject: Re: [PATCH 4.14 023/159] mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y Message-ID: <20180108083306.GA12893@kroah.com> References: <20171222084623.668990192@linuxfoundation.org> <20171222084625.007160464@linuxfoundation.org> <1515302062.6507.18.camel@gmx.de> <20180107091115.GB29329@kroah.com> <20180107101847.GC24862@dhcp22.suse.cz> <1515329042.13953.14.camel@gmx.de> <20180107132309.GD24862@dhcp22.suse.cz> <20180108075308.GC24062@kroah.com> <1515399333.20268.23.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515399333.20268.23.camel@gmx.de> Sender: owner-linux-mm@kvack.org List-ID: To: Mike Galbraith Cc: Michal Hocko , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Kirill A. Shutemov" , Andrew Morton , Andy Lutomirski , Borislav Petkov , Cyrill Gorcunov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , linux-mm@kvack.org, Ingo Molnar On Mon, Jan 08, 2018 at 09:15:33AM +0100, Mike Galbraith wrote: > On Mon, 2018-01-08 at 08:53 +0100, Greg Kroah-Hartman wrote: > > On Sun, Jan 07, 2018 at 02:23:09PM +0100, Michal Hocko wrote: > > > On Sun 07-01-18 13:44:02, Mike Galbraith wrote: > > > > On Sun, 2018-01-07 at 11:18 +0100, Michal Hocko wrote: > > > > > On Sun 07-01-18 10:11:15, Greg KH wrote: > > > > > > On Sun, Jan 07, 2018 at 06:14:22AM +0100, Mike Galbraith wrote: > > > > > > > On Fri, 2017-12-22 at 09:45 +0100, Greg Kroah-Hartman wrote: > > > > > > > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > > > FYI, this broke kdump, or rather the makedumpfile part thereof. > > > > > > > Forward looking wreckage is par for the kdump course, but... > > > > > > > > > > > > Is it also broken in Linus's tree with this patch? Or is there an > > > > > > add-on patch that I should apply to 4.14 to resolve this issue there? > > > > > > > > > > This one http://lkml.kernel.org/r/1513932498-20350-1-git-send-email-bhe@redhat.com > > > > > I guess. > > > > > > > > That won't unbreak kdump, else master wouldn't be broken. I don't care > > > > deeply, or know if anyone else does, I'm just reporting it because I > > > > met it and chased it down. > > > > > > OK, I didn't notice that d8cfbbfa0f7 ("mm/sparse.c: wrong allocation > > > for mem_section") made it in after rc6. I am still wondering why > > > 83e3c48729 ("mm/sparsemem: Allocate mem_section at runtime for > > > CONFIG_SPARSEMEM_EXTREME=y") made it into the stable tree in the first > > > place. > > > > It was part of the prep for the KTPI code from what I can tell. If you > > think it should be reverted, just let me know and I'll be glad to do so. > > No preference here. I have to patch master regardless if I want kdump > to work while I patiently wait for userspace to get fixed up (either > that or use time I don't have to go fix it up myself). I'll stay "bug compatible" for the time being. If you do fix this up, can you add a cc: stable tag in your patch so I can pick it up when it gets merged? thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org