From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933559AbeAHOjD (ORCPT + 1 other); Mon, 8 Jan 2018 09:39:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:44032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932575AbeAHOjB (ORCPT ); Mon, 8 Jan 2018 09:39:01 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23BD02173C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 8 Jan 2018 11:38:59 -0300 From: Arnaldo Carvalho de Melo To: Jin Yao Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v7 3/6] perf util: Create function to parse time percent Message-ID: <20180108143859.GC25476@kernel.org> References: <1512738826-2628-1-git-send-email-yao.jin@linux.intel.com> <1512738826-2628-4-git-send-email-yao.jin@linux.intel.com> <20180108143149.GB25476@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180108143149.GB25476@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Em Mon, Jan 08, 2018 at 11:31:49AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Dec 08, 2017 at 09:13:43PM +0800, Jin Yao escreveu: > > Current perf report/script/... have a --time option to limit the time > > range of output. But right now it only supports absolute time. > > > > For easy using, now it can support a percent of time usage. > > > > For example: > > > > 1. Select the second 10% time slice > > perf report --time 10%/2 > > After applying this patch I'm not being able to get any of these > examples to work: > > [root@jouet home]# perf report --header | grep "time of" > # time of first sample : 22947.909226 > # time of last sample : 22948.910704 > [root@jouet home]# > > Then, when I try the first example: > > [root@jouet home]# perf report --stdio --time 1%-20% > Invalid time string > # To display the perf.data header info, please use --header/--header-only options. > # > [root@jouet home]# > > What am I doing wrong? Oh well, the way you worded this cset it looked like after applying it I would be able to use percents, etc, which is not the case, I'll probably need to apply the next patches to _then_ this work as advertised in this cset comment. Please try to make it clear in the commit messages these details, to ease reviewing. - Arnaldo