From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755951AbeAIBfz (ORCPT + 1 other); Mon, 8 Jan 2018 20:35:55 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:42229 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754232AbeAIBft (ORCPT ); Mon, 8 Jan 2018 20:35:49 -0500 X-Google-Smtp-Source: ACJfBosMRyBqwIMJWEDSZig0UAswFdngQlc+/WdJQAYC0IokUMFj1P8k9DW+Zq1UtCGE6ZAcnoGroA== Date: Mon, 8 Jan 2018 17:35:46 -0800 From: Dmitry Torokhov To: Johan Hovold Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable , Peter Ujfalusi , "H . Nikolaus Schaller" Subject: Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup Message-ID: <20180109013546.k4hmjzvd37xvnu7t@dtor-ws> References: <20171111154339.16875-1-johan@kernel.org> <20171111154339.16875-2-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171111154339.16875-2-johan@kernel.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat, Nov 11, 2017 at 04:43:38PM +0100, Johan Hovold wrote: > Fix child-node lookup during probe, which ended up searching the whole > device tree depth-first starting at parent rather than just matching on > its children. > > Later sanity checks on node properties (which would likely be missing) > should prevent this from causing much trouble however, especially as the > original premature free of the parent node has already been fixed > separately (but that "fix" was apparently never backported to stable). > > Fixes: e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support") > Fixes: c52c545ead97 ("Input: twl6040-vibra - fix DT node memory management") > Cc: stable # 3.6 > Cc: Peter Ujfalusi > Cc: H. Nikolaus Schaller > Signed-off-by: Johan Hovold Applied, thank you. > --- > drivers/input/misc/twl6040-vibra.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c > index 5690eb7ff954..15e0d352c4cc 100644 > --- a/drivers/input/misc/twl6040-vibra.c > +++ b/drivers/input/misc/twl6040-vibra.c > @@ -248,8 +248,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev) > int vddvibr_uV = 0; > int error; > > - of_node_get(twl6040_core_dev->of_node); > - twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node, > + twl6040_core_node = of_get_child_by_name(twl6040_core_dev->of_node, > "vibra"); > if (!twl6040_core_node) { > dev_err(&pdev->dev, "parent of node is missing?\n"); > -- > 2.15.0 > -- Dmitry