From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 6/6] ethdev: return named opaque type
 instead of void pointer
Date: Tue, 9 Jan 2018 10:58:11 -0800
Message-ID: <20180109105811.2995412e@xeon-e3>
References: <20171201022957.64329-1-ferruh.yigit@intel.com>
 <20180109162317.18183-1-ferruh.yigit@intel.com>
 <20180109162317.18183-6-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, stable@dpdk.org,
 declan.doherty@intel.com, Boris Pismenny <borisp@mellanox.com>, Aviad
 Yehezkel <aviadye@mellanox.com>, Radu Nicolau <radu.nicolau@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68])
 by dpdk.org (Postfix) with ESMTP id B6BB51B1B8
 for <dev@dpdk.org>; Tue,  9 Jan 2018 19:58:13 +0100 (CET)
Received: by mail-pg0-f68.google.com with SMTP id f14so6025779pga.10
 for <dev@dpdk.org>; Tue, 09 Jan 2018 10:58:13 -0800 (PST)
In-Reply-To: <20180109162317.18183-6-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  9 Jan 2018 16:23:17 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> "struct rte_eth_rxtx_callback" is defined as internal data structure and
> used as named opaque type.
> 
> So the functions that are adding callbacks can return objects in this
> type instead of void pointer.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

My  comment was "yes I agree pointer should have opaque type"

Acked-by: Stephen Hemminger <stephen@networkplumber.org>