From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 1/4] drivers/mempool: add octeontx mempool driver to meson build Date: Tue, 9 Jan 2018 17:41:23 +0000 Message-ID: <20180109174123.GD6508@bricha3-MOBL3.ger.corp.intel.com> References: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: bluca@debian.org, harry.van.haaren@intel.com, jerin.jacob@caviumnetworks.com, dev@dpdk.org To: Pavan Nikhilesh Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0861D1B1BB for ; Tue, 9 Jan 2018 18:41:27 +0100 (CET) Content-Disposition: inline In-Reply-To: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote: > Add octeontx hardware mempool driver to meson build. > > Signed-off-by: Pavan Nikhilesh > --- On the set as a whole, it looks good to me, just the few minor nits pointed out in other emails. Can you do a V2 with those fixed? Also, I notice that you are missing License tags on the new files created, those should probably be added too in V2. Thanks, /Bruce