All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, Daniel Borkmann <borkmann@iogearbox.net>,
	linux-kernel@vger.kernel.org,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set
Date: Tue, 9 Jan 2018 14:57:40 -0800	[thread overview]
Message-ID: <20180109225740.GC26819@roeck-us.net> (raw)
In-Reply-To: <151553775426.22654.5680031281102493621.stgit@firesoul>

On Tue, Jan 09, 2018 at 11:42:34PM +0100, Jesper Dangaard Brouer wrote:
> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  include/linux/netdevice.h |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 440b000f07f4..b308793c64ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1805,12 +1805,9 @@ struct net_device {
>  	/* Interface address info used in eth_type_trans() */
>  	unsigned char		*dev_addr;
>  
> -#ifdef CONFIG_SYSFS
>  	struct netdev_rx_queue	*_rx;
> -
>  	unsigned int		num_rx_queues;
>  	unsigned int		real_num_rx_queues;
> -#endif
>  
>  	struct bpf_prog __rcu	*xdp_prog;
>  	unsigned long		gro_flush_timeout;
> 

  reply	other threads:[~2018-01-09 22:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 19:01 Build failure in -next due to 'xdp: generic XDP handling of xdp_rxq_info' Guenter Roeck
2018-01-09 22:37 ` Jesper Dangaard Brouer
2018-01-09 22:42   ` [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set Jesper Dangaard Brouer
2018-01-09 22:57     ` Guenter Roeck [this message]
2018-01-10 20:41     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109225740.GC26819@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alexei.starovoitov@gmail.com \
    --cc=borkmann@iogearbox.net \
    --cc=brouer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.