From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Date: Wed, 10 Jan 2018 10:51:35 +0000 Subject: Re: [PATCH 2/2] soundwire: Testing the wrong variable Message-Id: <20180110105544.GZ18649@localhost> List-Id: References: <20180109093700.7275ardpus7g6rkq@mwanda> <20180109093744.egp4vynjgghidp6i@mwanda> In-Reply-To: <20180109093744.egp4vynjgghidp6i@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Sanyog Kale , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org On Tue, Jan 09, 2018 at 12:37:44PM +0300, Dan Carpenter wrote: > We should be using "status2" here instead of "status". This is already fixed by commit: Author: Wei Yongjun Date: Mon Jan 8 22:22:44 2018 +0530 soundwire: Fix typo in return value check of sdw_read() Fix the typo, 'status' should be instead of 'status2'. > > Fixes: b0a9c37b0178 ("soundwire: Add slave status handling") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index ac88031f7664..a5d41a4a1609 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, > > /* Read DPN interrupt again */ > status2 = sdw_read(slave, addr); > - if (status < 0) { > + if (status2 < 0) { > dev_err(slave->bus->dev, > - "SDW_DPN_INT read failed:%d", status); > - return status; > + "SDW_DPN_INT read failed:%d", status2); > + return status2; > } > status &= status2; > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 2/2] soundwire: Testing the wrong variable Date: Wed, 10 Jan 2018 16:25:44 +0530 Message-ID: <20180110105544.GZ18649@localhost> References: <20180109093700.7275ardpus7g6rkq@mwanda> <20180109093744.egp4vynjgghidp6i@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180109093744.egp4vynjgghidp6i@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: Sanyog Kale , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Tue, Jan 09, 2018 at 12:37:44PM +0300, Dan Carpenter wrote: > We should be using "status2" here instead of "status". This is already fixed by commit: Author: Wei Yongjun Date: Mon Jan 8 22:22:44 2018 +0530 soundwire: Fix typo in return value check of sdw_read() Fix the typo, 'status' should be instead of 'status2'. > > Fixes: b0a9c37b0178 ("soundwire: Add slave status handling") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index ac88031f7664..a5d41a4a1609 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, > > /* Read DPN interrupt again */ > status2 = sdw_read(slave, addr); > - if (status < 0) { > + if (status2 < 0) { > dev_err(slave->bus->dev, > - "SDW_DPN_INT read failed:%d", status); > - return status; > + "SDW_DPN_INT read failed:%d", status2); > + return status2; > } > status &= status2; > -- ~Vinod