All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jingjing Wu <jingjing.wu@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v3 14/14] i40e: track id can be 0
Date: Wed, 10 Jan 2018 12:46:51 -0800	[thread overview]
Message-ID: <20180110204651.35717-15-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180110204651.35717-1-jeffrey.t.kirsher@intel.com>

From: Jingjing Wu <jingjing.wu@intel.com>

track_id == 0 is valid for “read only” profiles when
profile does not have any “write” commands.

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_common.c   | 5 -----
 drivers/net/ethernet/intel/i40evf/i40e_common.c | 5 -----
 2 files changed, 10 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c
index a196c3d305ab..40c5f7628aa1 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
@@ -5364,11 +5364,6 @@ i40e_write_profile(struct i40e_hw *hw, struct i40e_profile_segment *profile,
 	u32 offset = 0, info = 0;
 	u32 i;
 
-	if (!track_id) {
-		i40e_debug(hw, I40E_DEBUG_PACKAGE, "Track_id can't be 0.");
-		return I40E_NOT_SUPPORTED;
-	}
-
 	dev_cnt = profile->device_table_count;
 
 	for (i = 0; i < dev_cnt; i++) {
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c
index c1e473219957..a94648429a5b 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c
@@ -1330,11 +1330,6 @@ i40evf_write_profile(struct i40e_hw *hw, struct i40e_profile_segment *profile,
 	u32 offset = 0, info = 0;
 	u32 i;
 
-	if (!track_id) {
-		i40e_debug(hw, I40E_DEBUG_PACKAGE, "Track_id can't be 0.");
-		return I40E_NOT_SUPPORTED;
-	}
-
 	dev_cnt = profile->device_table_count;
 
 	for (i = 0; i < dev_cnt; i++) {
-- 
2.15.1

  parent reply	other threads:[~2018-01-10 20:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10 20:46 [net-next v3 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2018-01-10 Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 01/14] i40e: display priority_xon and priority_xoff stats Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 02/14] i40evf: don't rely on netif_running() outside rtnl_lock() Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 03/14] i40evf: use spinlock to protect (mac|vlan)_filter_list Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 04/14] i40evf: release bit locks in reverse order Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 05/14] i40evf: hold the critical task bit lock while opening Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 06/14] i40e: update VFs of link state after GET_VF_RESOURCES Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 07/14] i40e: add helper conversion function for link_speed Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 08/14] i40e/i40evf: Bump driver versions Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 09/14] i40e: remove redundant initialization of read_size Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 10/14] i40evf: Do not clear MSI-X PBA manually Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 11/14] i40evf: Clean-up flags for promisc mode to avoid high polling rate Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 12/14] i40evf: Drop i40evf_fire_sw_int as it is prone to races Jeff Kirsher
2018-01-10 20:46 ` [net-next v3 13/14] i40e: change ppp name to ddp Jeff Kirsher
2018-01-10 20:46 ` Jeff Kirsher [this message]
2018-01-11 17:00 ` [net-next v3 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2018-01-10 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110204651.35717-15-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jingjing.wu@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.