From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965477AbeAKSeX (ORCPT + 1 other); Thu, 11 Jan 2018 13:34:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37066 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935114AbeAKSeW (ORCPT ); Thu, 11 Jan 2018 13:34:22 -0500 Date: Thu, 11 Jan 2018 19:34:13 +0100 From: Oleg Nesterov To: Kirill Tkhai Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com, viro@zeniv.linux.org.uk, keescook@chromium.org, serge@hallyn.com, james.l.morris@oracle.com, luto@kernel.org, john.johansen@canonical.com, mingo@kernel.org, akpm@linux-foundation.org, mhocko@suse.com, peterz@infradead.org Subject: Re: [PATCH 3/4] tty: Iterate only thread group leaders in __do_SAK() Message-ID: <20180111183412.GA18725@redhat.com> References: <151568564127.6090.3546718160925256054.stgit@localhost.localdomain> <151568582337.6090.931248807289363396.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <151568582337.6090.931248807289363396.stgit@localhost.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 11 Jan 2018 18:34:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11, Kirill Tkhai wrote: > > Since threads can't have additional fd in comparison > to thread group leader ... > as they definitely have the same > files struct, as thread group leader. Hmm. Why? Iirc CLONE_THREAD doesn't require CLONE_FILES? Also. The group leader can exit, in this case its ->files == NULL but other threads can be alive. Oleg.