From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>, Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Hugh Dickins <hughd@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] selftests/x86: Add test_vsyscall
Date: Fri, 12 Jan 2018 08:32:55 +0100 [thread overview]
Message-ID: <20180112073255.GF25517@kroah.com> (raw)
In-Reply-To: <2b9c5a174c1d60fd7774461d518aa75598b1d8fd.1515719552.git.luto@kernel.org>
On Thu, Jan 11, 2018 at 05:16:51PM -0800, Andy Lutomirski wrote:
> This tests that the vsyscall entries do what they're expected to do.
> It also confirms that attempts to read the vsyscall page behave as
> expected.
>
> If changes are made to the vsyscall code or its memory map handling,
> running this test in all three of vsyscall=none, vsyscall=emulate,
> and vsyscall=native are helpful.
>
> (Because it's easy, this also compares the vsyscall results to their
> vDSO equivalents.)
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
Tested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Note to KAISER backporters: please test this under all three
> vsyscall modes. Also, in the emulate and native modes, make sure
> that test_vsyscall_64 agrees with the command line or config
> option as to which mode you're in. It's quite easy to mess up
> the kernel such that native mode accidentally emulates
> or vice versa.
>
> Greg, etc: please backport this to all your Meltdown-patched
> kernels. It'll help make sure the patches didn't regress
> vsyscalls.
I will gladly do so, thanks so much for this test.
greg k-h
next prev parent reply other threads:[~2018-01-12 7:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 1:16 [PATCH] selftests/x86: Add test_vsyscall Andy Lutomirski
2018-01-12 4:12 ` Kees Cook
2018-01-12 7:32 ` Greg Kroah-Hartman [this message]
2018-01-12 12:45 ` Ingo Molnar
2018-01-12 12:57 ` Ingo Molnar
2018-01-13 6:29 ` Andy Lutomirski
2018-01-13 10:20 ` Ingo Molnar
2018-01-13 6:22 ` Andy Lutomirski
2018-01-13 6:22 ` [Linux-kselftest-mirror] " Andy Lutomirski
2018-01-13 6:22 ` luto
2018-01-13 6:22 ` Andy Lutomirski
2018-01-13 10:28 ` [tip:x86/pti] " tip-bot for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112073255.GF25517@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=hughd@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.