From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933847AbeALMqC (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Fri, 12 Jan 2018 07:46:02 -0500
Received: from mail-wr0-f195.google.com ([209.85.128.195]:38491 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933681AbeALMp7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 12 Jan 2018 07:45:59 -0500
X-Google-Smtp-Source: ACJfBosbFFF2rsoutsnT2EM3Mk27oTYUFFlHRZNAItY9QmaW+bOcYAnzMkoya5M20TCyrrV9mjarig==
Date: Fri, 12 Jan 2018 13:45:53 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        Borislav Petkov <bp@alien8.de>,
        Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hugh Dickins <hughd@google.com>, stable@vger.kernel.org
Subject: Re: [PATCH] selftests/x86: Add test_vsyscall
Message-ID: <20180112124553.xd375lztfrrf4e5g@gmail.com>
References: <2b9c5a174c1d60fd7774461d518aa75598b1d8fd.1515719552.git.luto@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2b9c5a174c1d60fd7774461d518aa75598b1d8fd.1515719552.git.luto@kernel.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>


* Andy Lutomirski <luto@kernel.org> wrote:

> This tests that the vsyscall entries do what they're expected to do.
> It also confirms that attempts to read the vsyscall page behave as
> expected.
> 
> If changes are made to the vsyscall code or its memory map handling,
> running this test in all three of vsyscall=none, vsyscall=emulate,
> and vsyscall=native are helpful.
> 
> (Because it's easy, this also compares the vsyscall results to their
>  vDSO equivalents.)
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> 
> Note to KAISER backporters: please test this under all three
> vsyscall modes.  Also, in the emulate and native modes, make sure
> that test_vsyscall_64 agrees with the command line or config
> option as to which mode you're in.  It's quite easy to mess up
> the kernel such that native mode accidentally emulates
> or vice versa.
> 
> Greg, etc: please backport this to all your Meltdown-patched
> kernels.  It'll help make sure the patches didn't regress
> vsyscalls.

I've added this to tip:x86/pti, that way it will end up in the linear backport 
range of commits.

Thanks,

	Ingo