From: Lukas Wunner <email@example.com> To: Sinan Kaya <firstname.lastname@example.org> Cc: Bjorn Helgaas <email@example.com>, Mika Westerberg <firstname.lastname@example.org>, Yehezkel Bernat <email@example.com>, Michael Jamet <firstname.lastname@example.org>, email@example.com Subject: Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown Date: Sat, 13 Jan 2018 08:32:18 +0100 [thread overview] Message-ID: <20180113073218.GB14854@wunner.de> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri, Jan 12, 2018 at 10:31:12AM -0500, Sinan Kaya wrote: > On 1/12/2018 10:12 AM, Lukas Wunner wrote: > > On Fri, Jan 12, 2018 at 09:26:48AM -0500, Sinan Kaya wrote: > >> On 1/12/2018 5:49 AM, Lukas Wunner wrote: > >> I wonder if we can separate remove from shutdown and just disable the IRQs > >> in shutdown case rather than turning off the slot power etc. > > > > But don't we risk "IRQ xx: nobody cared" splats if we do that? > > I assumed code was turning off the slot power etc. aggressively. > > After looking at the code some more time, it seems to be doing the > right thing and telling pcie controller not to generate interrupts for > hotplug. > > I think this is what is failing for you probably because by the time you are > shutting down there is nobody to issue the command completion. This would > repeat for each hotplug capable pcie slot. You mean we disable Command Completed interrupts and thus the port can't notify that the command was completed? It seems the code accommodates to that by polling the PCI_EXP_SLTSTA_CC bit: if (ctrl->slot_ctrl & PCI_EXP_SLTCTL_HPIE && ctrl->slot_ctrl & PCI_EXP_SLTCTL_CCIE) rc = wait_event_timeout(ctrl->queue, !ctrl->cmd_busy, timeout); else rc = pcie_poll_cmd(ctrl, jiffies_to_msecs(timeout)); The problem is that these Thunderbolt controllers never seem to set the PCI_EXP_SLTSTA_CC bit, resulting in "Timeout on hotplug command" messages. The pciehp code is okay, we just need a workaround for the broken Thunderbolt 1 chips. This has been a pain point all along, but your patch made the brokenness visible enough that investigating and fixing it became unavoidable. So don't worry about your patch, it's all fine. ;-) Thanks, Lukas
next prev parent reply other threads:[~2018-01-13 7:32 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-12 10:49 Lukas Wunner 2018-01-12 11:03 ` Lukas Wunner 2018-01-12 14:26 ` Sinan Kaya 2018-01-12 15:12 ` Lukas Wunner 2018-01-12 15:31 ` Sinan Kaya 2018-01-13 7:32 ` Lukas Wunner [this message] 2018-01-13 17:58 ` okaya 2018-01-13 19:39 ` Lukas Wunner 2018-01-13 20:49 ` okaya 2018-01-12 16:34 ` Mika Westerberg 2018-01-13 7:14 ` Lukas Wunner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180113073218.GB14854@wunner.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.