All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, "Lluís Vilanova" <vilanova@ac.upc.edu>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages
Date: Mon, 15 Jan 2018 14:03:52 +0000	[thread overview]
Message-ID: <20180115140352.GI13238@stefanha-x1.localdomain> (raw)
In-Reply-To: <cb5cf329-50b6-845b-ff74-cd0001778611@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

On Wed, Jan 10, 2018 at 02:48:16PM -0600, Eric Blake wrote:
> On 01/10/2018 02:25 PM, Stefan Hajnoczi wrote:
> > This series improves the tracetool error messages to make them more
> > user-friendly.
> > 
> > Stefan Hajnoczi (3):
> >   tracetool: prefix parse errors with line numbers
> >   tracetool: clarify that "formats" means "format strings"
> >   tracetool: report error on foo() instead of foo(void)
> 
> Series:
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> but see nit on patch 1

Thanks, will fix!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2018-01-15 14:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10 20:25 [Qemu-devel] [PATCH 0/3] tracetool: improve error messages Stefan Hajnoczi
2018-01-10 20:25 ` [Qemu-devel] [PATCH 1/3] tracetool: prefix parse errors with line numbers Stefan Hajnoczi
2018-01-10 20:47   ` Eric Blake
2018-01-10 20:25 ` [Qemu-devel] [PATCH 2/3] tracetool: clarify that "formats" means "format strings" Stefan Hajnoczi
2018-01-10 20:25 ` [Qemu-devel] [PATCH 3/3] tracetool: report error on foo() instead of foo(void) Stefan Hajnoczi
2018-01-10 20:48 ` [Qemu-devel] [PATCH 0/3] tracetool: improve error messages Eric Blake
2018-01-15 14:03   ` Stefan Hajnoczi [this message]
2018-01-10 21:06 ` no-reply
2018-01-15 14:11 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115140352.GI13238@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.