All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH V4 0/2] mtd: simplify mtd_device_parse_register code
Date: Mon, 15 Jan 2018 23:45:45 +0100	[thread overview]
Message-ID: <20180115224547.9265-1-zajec5@gmail.com> (raw)
In-Reply-To: <20180115143519.9845-1-zajec5@gmail.com>

From: Rafał Miłecki <rafal@milecki.pl>

Even though I have some experience with MTD subsystem every time I was
starting working on it I had to do some quick research on the code flow.
I think there is some place for cleanup and optimization that would
simplify overall code and allow new developers to start working on it
more easily.

In these patches I meant to slightly simplify mtd_device_parse_register
function. I think we could reduce amount of add/register/del functions
and this is the first step for that.

Ideally I think mtdcore.c shouldn't handle parsing but just use a single
function from mtdpart.c.

Patch 1/2 modifies code to make sure parsing code is not mixed with MTD
master code. This should allow moving parsing parts to the mtdpart.c in
the future.

Patch 2/2 simplifies code and makes sure parsing is handled at 1 place
only.

Even though this cleanup isn't complete I think it already has some
value and could be accepted (if there won't be objections) on its own.
It's also quite small which should allow reviewing it easily.

Rafał Miłecki (2):
  mtd: move code adding master MTD out of mtd_add_device_partitions
  mtd: get rid of the mtd_add_device_partitions function

 drivers/mtd/mtdcore.c | 58 ++++++++++++++++++---------------------------------
 1 file changed, 20 insertions(+), 38 deletions(-)

-- 
2.11.0

  parent reply	other threads:[~2018-01-15 22:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 14:40 [PATCH 0/2] mtd: simplify mtd_device_parse_register code Rafał Miłecki
2018-01-12 14:40 ` [PATCH 1/2] mtd: move code adding master MTD out of mtd_add_device_partitions Rafał Miłecki
2018-01-12 15:01   ` Boris Brezillon
2018-01-15 10:58     ` Rafał Miłecki
2018-01-12 14:40 ` [PATCH 2/2] mtd: get rid of the mtd_add_device_partitions function Rafał Miłecki
2018-01-12 15:11   ` Boris Brezillon
2018-01-15 12:56     ` Rafał Miłecki
2018-01-15 13:22 ` [PATCH V2 0/2] mtd: simplify mtd_device_parse_register code Rafał Miłecki
2018-01-15 13:22   ` [PATCH V2 1/2] mtd: move code adding master MTD out of mtd_add_device_partitions Rafał Miłecki
2018-01-15 13:36     ` Boris Brezillon
2018-01-15 13:22   ` [PATCH V2 2/2] mtd: get rid of the mtd_add_device_partitions function Rafał Miłecki
2018-01-15 14:35   ` [PATCH V3 0/2] mtd: simplify mtd_device_parse_register code Rafał Miłecki
2018-01-15 14:35     ` [PATCH V3 1/2] mtd: move code adding master MTD out of mtd_add_device_partitions Rafał Miłecki
2018-01-15 14:35     ` [PATCH V3 2/2] mtd: get rid of the mtd_add_device_partitions function Rafał Miłecki
2018-01-15 22:45     ` Rafał Miłecki [this message]
2018-01-15 22:45       ` [PATCH V4 1/2] mtd: move code adding master MTD out of mtd_add_device_partitions Rafał Miłecki
2018-01-15 22:45       ` [PATCH V4 2/2] mtd: get rid of the mtd_add_device_partitions() Rafał Miłecki
     [not found]       ` <20180116154542.9767-1-zajec5@gmail.com>
2018-02-17  8:38         ` [PATCH V5 0/2] mtd: simplify mtd_device_parse_register() code Boris Brezillon
2018-02-18  7:50           ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115224547.9265-1-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.