All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: don't return garbage pointer on modprobe failure
Date: Tue, 16 Jan 2018 01:53:14 +0100	[thread overview]
Message-ID: <20180116005314.i7j33bt7hehh4n3v@salvia> (raw)
In-Reply-To: <20180113130608.13079-1-fw@strlen.de>

On Sat, Jan 13, 2018 at 02:06:08PM +0100, Florian Westphal wrote:
> request_module may return a positive error result from modprobe,
> if we cast this to ERR_PTR this returns a garbage result (it passes
> IS_ERR checks).
> 
> Fix it by ignoring modprobe return values entirely, just retry the
> table lookup instead.

Applied, thanks Florian.

      reply	other threads:[~2018-01-16  0:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 22:58 general protection fault in get_info syzbot
2018-01-13 13:06 ` [PATCH nf-next] netfilter: don't return garbage pointer on modprobe failure Florian Westphal
2018-01-16  0:53   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180116005314.i7j33bt7hehh4n3v@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.