From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next 0/8] net: sched: cls: add extack support Date: Tue, 16 Jan 2018 13:46:54 -0800 Message-ID: <20180116134654.10d4fdef@cakuba.netronome.com> References: <20180116172027.22128-1-aring@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com, David Ahern To: Alexander Aring Return-path: Received: from mx3.wp.pl ([212.77.101.9]:50273 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbeAPVrD (ORCPT ); Tue, 16 Jan 2018 16:47:03 -0500 In-Reply-To: <20180116172027.22128-1-aring@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 16 Jan 2018 12:20:19 -0500, Alexander Aring wrote: > Hi, > > this patch adds extack support for TC classifier subsystem. The first > patch fixes some code style issues for this patch series pointed out > by checkpatch. The other patches until the last one prepares extack > handling for the TC classifier subsystem and handle generic extack > errors. > > The last patch is an example for u32 classifier to add extack support > inside the callbacks delete and change. There exists a init callback as > well, but most classifier implementation run a kalloc() once to allocate > something. Not necessary _yet_ to add extack support now. > > I know there are patches around which makes changes to these files. > I will rebase my stuff on Jiri's patches if they get in before mine. Ugh, this is going to conflict with our series too :( (and I CCed you on ours) Would it be OK for you to hold off until Jiri's code gets merged and ours comes down via bpf-next? That shouldn't take long at all. The conflicts between bpf/bpf-next/net-next are really taking their toll on us this release cycles, I would really appreciate if we could make some progress on this relatively simple series at least...