From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751258AbeAPSEo (ORCPT + 1 other); Tue, 16 Jan 2018 13:04:44 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:39902 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbeAPSEn (ORCPT ); Tue, 16 Jan 2018 13:04:43 -0500 X-Google-Smtp-Source: ACJfBotg/9ZOHnZqdqr4JoA3r+pAVnC5E03Os9X66yD+VCIEuQhbkx3XGxHTFQd4qO6e+qSAAaa8+Q== Date: Tue, 16 Jan 2018 11:04:38 -0700 From: Mathieu Poirier To: Jiri Olsa Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, adrian.hunter@intel.com, mike.leach@arm.com, suzuki.poulosi@arm.com, kim.phillips@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library Message-ID: <20180116180438.GB10320@xps15> References: <1516039994-314-1-git-send-email-mathieu.poirier@linaro.org> <1516039994-314-2-git-send-email-mathieu.poirier@linaro.org> <20180116121500.GB26643@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116121500.GB26643@krava> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 01:15:00PM +0100, Jiri Olsa wrote: > On Mon, Jan 15, 2018 at 11:13:05AM -0700, Mathieu Poirier wrote: > > The Open CoreSight Decoding Library (openCSD) is a free and open > > library to decode traces collected by the CoreSight hardware > > infrastructure. > > > > This patch adds the required mechanic to recognise the presence > > of the openCSD library on a system and set up miscellaneous flags > > to be used in the compilation of the trace decoding feature. > > > > Signed-off-by: Mathieu Poirier > > --- > > tools/build/Makefile.feature | 6 ++++-- > > tools/build/feature/Makefile | 7 ++++++- > > tools/build/feature/test-all.c | 5 +++++ > > tools/build/feature/test-libopencsd.c | 8 ++++++++ > > tools/perf/Makefile.config | 25 +++++++++++++++++++++++++ > > tools/perf/Makefile.perf | 2 ++ > > 6 files changed, 50 insertions(+), 3 deletions(-) > > create mode 100644 tools/build/feature/test-libopencsd.c > > > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > > index e52fcefee379..dc3d97b248ab 100644 > > --- a/tools/build/Makefile.feature > > +++ b/tools/build/Makefile.feature > > @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \ > > bpf \ > > sched_getcpu \ > > sdt \ > > - setns > > + setns \ > > + libopencsd > > > > # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list > > # of all feature tests > > @@ -108,7 +109,8 @@ FEATURE_DISPLAY ?= \ > > zlib \ > > lzma \ > > get_cpuid \ > > - bpf > > + bpf \ > > + libopencsd > > we put in this list only generic libraries, this one seems arch > specific please put it into FEATURE_TESTS_EXTRA list Very well - thanks for taking the time to review my work. Mathieu > > the state is displayed by running make 'VF=1', with this patch: > https://marc.info/?l=linux-kernel&m=151549001914932&w=2 > > Arnaldo, could you please check on that one ^^^? > > thanks, > jirka