From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbeAQCV6 (ORCPT + 1 other); Tue, 16 Jan 2018 21:21:58 -0500 Received: from mga01.intel.com ([192.55.52.88]:63949 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbeAQCV5 (ORCPT ); Tue, 16 Jan 2018 21:21:57 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,371,1511856000"; d="scan'208";a="19977946" Date: Tue, 16 Jan 2018 19:25:11 -0700 From: Keith Busch To: Thomas Gleixner Cc: LKML Subject: Re: [BUG 4.15-rc7] IRQ matrix management errors Message-ID: <20180117022511.GD6259@localhost.localdomain> References: <20180115025759.GG13580@localhost.localdomain> <20180115030255.GA13921@localhost.localdomain> <20180116061641.GB32639@localhost.localdomain> <20180116071145.GA5643@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 12:20:18PM +0100, Thomas Gleixner wrote: > 8<---------------------- > diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c > index f8b03bb8e725..3cc471beb50b 100644 > --- a/arch/x86/kernel/apic/vector.c > +++ b/arch/x86/kernel/apic/vector.c > @@ -542,14 +542,17 @@ static int x86_vector_alloc_irqs(struct irq_domain *domain, unsigned int virq, > > err = assign_irq_vector_policy(irqd, info); > trace_vector_setup(virq + i, false, err); > - if (err) > + if (err) { > + irqd->chip_data = NULL; > + free_apic_chip_data(apicd); > goto error; > + } > } > > return 0; > > error: > - x86_vector_free_irqs(domain, virq, i + 1); > + x86_vector_free_irqs(domain, virq, i); > return err; > } > The patch does indeed fix all the warnings and allows device binding to succeed, albeit in a degraded performance mode. Despite that, this is a good fix, and looks applicable to 4.4-stable, so: Tested-by: Keith Busch I'm still concerned assign_irq_vector_policy is failing. That has interrupt allocation abandon MSI-x and fall back to legacy IRQ. Your patch does address my main concern, though. Are you comfortable enough to queue this up for 4.15? Thanks, Keith