All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sparse doesn't support struct randomization
@ 2018-01-17  2:45 Matthew Wilcox
  2018-01-17  3:55 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2018-01-17  2:45 UTC (permalink / raw)
  To: Ingo Molnar, Josh Poimboeuf, Kees Cook, Andrew Morton, linux-kernel
  Cc: Matthew Wilcox

From: Matthew Wilcox <mawilcox@microsoft.com>

Without this patch, I drown in a sea of unknown attribute warnings

Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
---
 include/linux/compiler-gcc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 2272ded07496..631354acfa72 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -219,7 +219,7 @@
 /* Mark a function definition as prohibited from being cloned. */
 #define __noclone	__attribute__((__noclone__, __optimize__("no-tracer")))
 
-#ifdef RANDSTRUCT_PLUGIN
+#if defined(RANDSTRUCT_PLUGIN) && !defined(__CHECKER__)
 #define __randomize_layout __attribute__((randomize_layout))
 #define __no_randomize_layout __attribute__((no_randomize_layout))
 #endif
-- 
2.15.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sparse doesn't support struct randomization
  2018-01-17  2:45 [PATCH] sparse doesn't support struct randomization Matthew Wilcox
@ 2018-01-17  3:55 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2018-01-17  3:55 UTC (permalink / raw)
  To: Matthew Wilcox
  Cc: Ingo Molnar, Josh Poimboeuf, Andrew Morton, LKML, Matthew Wilcox

On Tue, Jan 16, 2018 at 6:45 PM, Matthew Wilcox <willy@infradead.org> wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
>
> Without this patch, I drown in a sea of unknown attribute warnings
>
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>

Thanks!

Acked-by: Kees Cook <keescook@chromium.org>

Andrew, are you able to take this? I have no other gcc-plugin changes
pending for the coming merge window...

-Kees

> ---
>  include/linux/compiler-gcc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 2272ded07496..631354acfa72 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -219,7 +219,7 @@
>  /* Mark a function definition as prohibited from being cloned. */
>  #define __noclone      __attribute__((__noclone__, __optimize__("no-tracer")))
>
> -#ifdef RANDSTRUCT_PLUGIN
> +#if defined(RANDSTRUCT_PLUGIN) && !defined(__CHECKER__)
>  #define __randomize_layout __attribute__((randomize_layout))
>  #define __no_randomize_layout __attribute__((no_randomize_layout))
>  #endif
> --
> 2.15.1
>



-- 
Kees Cook
Pixel Security

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-17  3:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17  2:45 [PATCH] sparse doesn't support struct randomization Matthew Wilcox
2018-01-17  3:55 ` Kees Cook

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.