From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>, dm-devel@redhat.com
Cc: Ritika Srivastava <ritika.srivastava@oracle.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
Martin Wilck <mwilck@suse.com>
Subject: [PATCH 0/7] multipath-tools: uevent processing fixes and unit tests
Date: Wed, 17 Jan 2018 08:49:32 +0100 [thread overview]
Message-ID: <20180117074939.7795-1-mwilck@suse.com> (raw)
Hi Christophe,
The incentive for creating this series was Ritika's patch "multipath-tools:
Skip CHANGE uevent for non-mpath devices" from October 2017, plus the
observation that uevent.c contains a lot of code repetition.
I've refactored and simplified the uevent_get_XXX code, and started to use
"const" qualifiers in the part of the code which I touched in the process.
In order to avoid regressions in the process, I took this as a starting point
for implementing a simple unit test framework. For now, it covers only the
stuff that I changed in this series.
The series is based on my previous patch series ("Various
multipath-tools fixes"), v2. The first patch doesn't belong in the series
logically, but I thought it may help you track the ordering if I include it
here rather then posting separately or spamming the list with the big series
again.
Regards,
Martin
Martin Wilck (7):
assemble_map: no newline at end of params string
tests: cmocka-based unit test for uevent_get_XXX
libmultipath: refactor uevent_get_XXX
libmultipath: const qualifier for wwid and alias
libmultipath: move UUID_PREFIX to devmapper.h
libmultipath: add uevent_is_mpath
multipathd: ignore uevents for non-mpath devices
.gitignore | 3 +
Makefile | 4 +
libmultipath/devmapper.c | 3 -
libmultipath/devmapper.h | 3 +
libmultipath/discovery.c | 2 +-
libmultipath/discovery.h | 2 +-
libmultipath/dmparser.c | 1 -
libmultipath/memory.h | 2 +-
libmultipath/structs.c | 4 +-
libmultipath/structs.h | 4 +-
libmultipath/structs_vec.c | 2 +-
libmultipath/structs_vec.h | 2 +-
libmultipath/uevent.c | 183 +++++++++++++--------------
libmultipath/uevent.h | 15 +--
multipathd/main.c | 10 +-
multipathd/main.h | 2 +-
tests/Makefile | 23 ++++
tests/globals.c | 17 +++
tests/uevent.c | 304 +++++++++++++++++++++++++++++++++++++++++++++
19 files changed, 462 insertions(+), 124 deletions(-)
create mode 100644 tests/Makefile
create mode 100644 tests/globals.c
create mode 100644 tests/uevent.c
--
2.15.1
next reply other threads:[~2018-01-17 7:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 7:49 Martin Wilck [this message]
2018-01-17 7:49 ` [PATCH 1/7] assemble_map: no newline at end of params string Martin Wilck
2018-01-17 7:49 ` [PATCH 2/7] tests: cmocka-based unit test for uevent_get_XXX Martin Wilck
2018-01-17 7:49 ` [PATCH 3/7] libmultipath: refactor uevent_get_XXX Martin Wilck
2018-01-17 7:49 ` [PATCH 4/7] libmultipath: const qualifier for wwid and alias Martin Wilck
2018-01-17 7:49 ` [PATCH 5/7] libmultipath: move UUID_PREFIX to devmapper.h Martin Wilck
2018-01-17 7:49 ` [PATCH 6/7] libmultipath: add uevent_is_mpath Martin Wilck
2018-01-17 7:49 ` [PATCH 7/7] multipathd: ignore uevents for non-mpath devices Martin Wilck
2018-01-29 22:25 ` Ritika Srivastava
2018-01-29 23:44 ` Martin Wilck
2018-01-29 23:57 ` [PATCH v2] " Martin Wilck
2018-02-07 19:14 ` Ritika Srivastava
2018-02-07 18:35 ` [PATCH 0/7] multipath-tools: uevent processing fixes and unit tests Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117074939.7795-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=ritika.srivastava@oracle.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.