From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752343AbeAQIGs (ORCPT + 1 other); Wed, 17 Jan 2018 03:06:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbeAQIGr (ORCPT ); Wed, 17 Jan 2018 03:06:47 -0500 Date: Wed, 17 Jan 2018 09:06:40 +0100 From: Jiri Olsa To: Mathieu Poirier Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , namhyung@kernel.org, Adrian Hunter , Mike Leach , suzuki.poulosi@arm.com, Kim Phillips , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library Message-ID: <20180117080640.GD6183@krava> References: <1516039994-314-1-git-send-email-mathieu.poirier@linaro.org> <1516039994-314-2-git-send-email-mathieu.poirier@linaro.org> <20180116121500.GB26643@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 17 Jan 2018 08:06:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 01:30:33PM -0700, Mathieu Poirier wrote: > On 16 January 2018 at 05:15, Jiri Olsa wrote: > > On Mon, Jan 15, 2018 at 11:13:05AM -0700, Mathieu Poirier wrote: > >> The Open CoreSight Decoding Library (openCSD) is a free and open > >> library to decode traces collected by the CoreSight hardware > >> infrastructure. > >> > >> This patch adds the required mechanic to recognise the presence > >> of the openCSD library on a system and set up miscellaneous flags > >> to be used in the compilation of the trace decoding feature. > >> > >> Signed-off-by: Mathieu Poirier > >> --- > >> tools/build/Makefile.feature | 6 ++++-- > >> tools/build/feature/Makefile | 7 ++++++- > >> tools/build/feature/test-all.c | 5 +++++ > >> tools/build/feature/test-libopencsd.c | 8 ++++++++ > >> tools/perf/Makefile.config | 25 +++++++++++++++++++++++++ > >> tools/perf/Makefile.perf | 2 ++ > >> 6 files changed, 50 insertions(+), 3 deletions(-) > >> create mode 100644 tools/build/feature/test-libopencsd.c > >> > >> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > >> index e52fcefee379..dc3d97b248ab 100644 > >> --- a/tools/build/Makefile.feature > >> +++ b/tools/build/Makefile.feature > >> @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \ > >> bpf \ > >> sched_getcpu \ > >> sdt \ > >> - setns > >> + setns \ > >> + libopencsd > >> > >> # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list > >> # of all feature tests > >> @@ -108,7 +109,8 @@ FEATURE_DISPLAY ?= \ > >> zlib \ > >> lzma \ > >> get_cpuid \ > >> - bpf > >> + bpf \ > >> + libopencsd > > > > we put in this list only generic libraries, this one seems arch > > specific please put it into FEATURE_TESTS_EXTRA list > > Humm... Jiri, > > I was thinking that libopencsd should fall in the same category as > libunwind-arm and libunwind-aarch64. Both are not architecture > specific and used to process traces acquired on ARM platforms. As > such I suggest to keep libopencsd as part of FEATURE_TESTS_BASIC and > remove it from under FEATURE_DISPLAY - how does that sound to you? > ok, that sounds good jirka From mboxrd@z Thu Jan 1 00:00:00 1970 From: jolsa@redhat.com (Jiri Olsa) Date: Wed, 17 Jan 2018 09:06:40 +0100 Subject: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library In-Reply-To: References: <1516039994-314-1-git-send-email-mathieu.poirier@linaro.org> <1516039994-314-2-git-send-email-mathieu.poirier@linaro.org> <20180116121500.GB26643@krava> Message-ID: <20180117080640.GD6183@krava> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 16, 2018 at 01:30:33PM -0700, Mathieu Poirier wrote: > On 16 January 2018 at 05:15, Jiri Olsa wrote: > > On Mon, Jan 15, 2018 at 11:13:05AM -0700, Mathieu Poirier wrote: > >> The Open CoreSight Decoding Library (openCSD) is a free and open > >> library to decode traces collected by the CoreSight hardware > >> infrastructure. > >> > >> This patch adds the required mechanic to recognise the presence > >> of the openCSD library on a system and set up miscellaneous flags > >> to be used in the compilation of the trace decoding feature. > >> > >> Signed-off-by: Mathieu Poirier > >> --- > >> tools/build/Makefile.feature | 6 ++++-- > >> tools/build/feature/Makefile | 7 ++++++- > >> tools/build/feature/test-all.c | 5 +++++ > >> tools/build/feature/test-libopencsd.c | 8 ++++++++ > >> tools/perf/Makefile.config | 25 +++++++++++++++++++++++++ > >> tools/perf/Makefile.perf | 2 ++ > >> 6 files changed, 50 insertions(+), 3 deletions(-) > >> create mode 100644 tools/build/feature/test-libopencsd.c > >> > >> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > >> index e52fcefee379..dc3d97b248ab 100644 > >> --- a/tools/build/Makefile.feature > >> +++ b/tools/build/Makefile.feature > >> @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \ > >> bpf \ > >> sched_getcpu \ > >> sdt \ > >> - setns > >> + setns \ > >> + libopencsd > >> > >> # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list > >> # of all feature tests > >> @@ -108,7 +109,8 @@ FEATURE_DISPLAY ?= \ > >> zlib \ > >> lzma \ > >> get_cpuid \ > >> - bpf > >> + bpf \ > >> + libopencsd > > > > we put in this list only generic libraries, this one seems arch > > specific please put it into FEATURE_TESTS_EXTRA list > > Humm... Jiri, > > I was thinking that libopencsd should fall in the same category as > libunwind-arm and libunwind-aarch64. Both are not architecture > specific and used to process traces acquired on ARM platforms. As > such I suggest to keep libopencsd as part of FEATURE_TESTS_BASIC and > remove it from under FEATURE_DISPLAY - how does that sound to you? > ok, that sounds good jirka