All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
	Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>,
	Michael Petlan <mpetlan@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
	linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 3/5] perf util: Introduce architecture specific errno/name mapping
Date: Wed, 17 Jan 2018 09:49:35 +0100	[thread overview]
Message-ID: <20180117084935.GB4470@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180116135848.GC25687@kernel.org>

On Tue, Jan 16, 2018 at 10:58:48AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 16, 2018 at 10:46:29AM +0100, Hendrik Brueckner escreveu:
> > Introduce a script that generates a mapping of errno numbers to
> > their names for each architecture that is supported by perf (i.e.
> > has a subdirectory in tools/perf/arch/).
> > 
> > The file is generated as util/errno-names.c.  A corresponding
> > header file util/errno-names.h is provided that defines the
> > arch_errno_to_name() function.  Use arch_errno_to_name() to
> > lookup an errno value to obtain the errno name (e.g. ENOENT)
> > for a particular architecture.
> > 
> > This is to be used by perf trace.
> 
> Ok, this is almost there, one nit I think needs to be fixed, instead of
> generating it on $(OUTPUT)util/errno-names.c we can generate it here:
> 
[...]
> 
> I.e. all these are beautifier routines generated by shell scripts from
> kernel header copies, so I think this new one, for errno, belongs there,
> ok?

At the moment, just perf trace use this interface. Hence, putting it to
the trace beautifiers makes sense.  Will update the patch accordingly and
re-post a v2 of the patch again.

Additional feedback is welcome... so I can decide whether to post the
single patch or an updated series.


Thanks and kind regards,
  Hendrik

  reply	other threads:[~2018-01-17  8:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  9:46 [PATCH 0/5] perf trace: Introduce arch-specific errno code/name mappings Hendrik Brueckner
2018-01-16  9:46 ` [PATCH 1/5] tools include arch: Grab a copy of errno.h for arch's supported by perf Hendrik Brueckner
2018-01-16  9:46 ` [PATCH 2/5] tools include asm-generic: Grab errno.h and errno-base.h Hendrik Brueckner
2018-01-16  9:46 ` [PATCH 3/5] perf util: Introduce architecture specific errno/name mapping Hendrik Brueckner
2018-01-16 13:58   ` Arnaldo Carvalho de Melo
2018-01-17  8:49     ` Hendrik Brueckner [this message]
2018-01-18 10:07   ` Jiri Olsa
2018-01-18 10:49     ` Arnaldo Carvalho de Melo
2018-01-18 11:33       ` Hendrik Brueckner
2018-01-18 14:11         ` Arnaldo Carvalho de Melo
2018-01-18 12:19       ` Jiri Olsa
2018-01-16  9:46 ` [PATCH 4/5] perf trace: Obtain errno values by using arch_errno_to_name() Hendrik Brueckner
2018-01-16  9:46 ` [PATCH 5/5] perf trace: Remove audit-libs dependency if syscall tables are present Hendrik Brueckner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117084935.GB4470@linux.vnet.ibm.com \
    --to=brueckner@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=tmricht@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.